Repository navigation
chore(labrinth): bump to async-stripe 1.x - #8268
Merged
Merged
Conversation
fetchfern
marked this pull request as ready for review
November 9, 2026 20:16
- Pin `capture_method` to `automatic` on new payment intents, since the pinned Stripe API version defaults to asynchronous capture, which leaves the charge without a balance transaction when `payment_intent.succeeded` is handled - Wrap Stripe errors with a concise type/code/message description instead of the SDK's full debug dump, which could include payment intents, payment methods and client secrets in logs and API error details - Enable the `deserialize` feature on the Stripe crates and drop the direct `miniserde` dependency - Ignore the `ba_` payment method ID prefix in the typos check
 [Critical impact] The PR reaches the payment and subscription flows that move money and update billing records. The new error messages must satisfy the repository’s lowercase requirement before merging; the redaction test is a non-blocking improvement. Reviews (1) · Last reviewed commit: "chore: various fixes" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
clrxbl
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.