Repository navigation
Conversation
Signed-off-by: Ceebug <caseydegan@outlook.com>
Updated various div elements to include min-w-0 and truncate classes for better layout handling. Signed-off-by: Ceebug <caseydegan@outlook.com>
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
|
Sorry for last time @Prospector, first time doing prs to something. still learning |
|
can someone have a look at this pr? |
|
Im not able to reproduce any overflow issues with the jump in cards. Could you send some before and after pictures to show the issue and the fix? |
|
I will |
|
done @tdgao |
also that might be because of my laptop screen size and scale. |
IMB11
left a comment
IMB11
left a comment
There was a problem hiding this comment.
Looks fine just one change needed
| <div | ||
| v-else-if="world.type === 'server'" | ||
| class="text-sm text-secondary flex items-center gap-1 font-semibold flex-nowrap whitespace-nowrap" | ||
| class="text-sm text-secondary flex items-center gap-1 font-semibold flex-nowrap whitespace-nowrap min-w-0 truncate" |
There was a problem hiding this comment.
need to use the truncate.ts we have in packages/ui if text is truncated to show a tooltip on hover
There was a problem hiding this comment.
ive spent 4 hours trying to get this working, i have followed the example exactly to the best of my ability. i still have not gotten it working :(
may i pls ask for some help from u guys
|
This pull request is closed, so it cannot be queued. Reopen it to get the box back. |
Fixes:
Text overflow fix screenshots:
Before
After
Card overflow fix screenshots:
Before
After