Skip to content

fix: update ty stub-body suppressions - #752

Merged
lesnik512 merged 1 commit into
mainfrom
fix/751-ty-rule-renames
Nov 13, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
fix/751-ty-rule-renames

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Scheduled CI fails with ty 0.0.103 because five empty-body suppressions use a renamed rule. Update them to invalid-implicit-return-in-function-with-stub-body.

Validation: reproduced the five diagnostics before the change; just lint-ci test-ci now passes with 1,125 tests passed, 3 skipped, and 100% line and branch coverage.

Fixes #751.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 7fa1fa2 Previous: 4562ac9 Ratio
benchmarks/test_guard_by_type.py::test_g16_resolve_by_type 4883597.023155325 iter/sec (stddev: 7.95307794518759e-9) 3257719.8105003904 iter/sec (stddev: 3.829196616321983e-8) 0.67
benchmarks/test_guard_by_type.py::test_g17_resolve_by_type_large_registry 5135419.207089443 iter/sec (stddev: 8.874629856698423e-9) 3374186.521577108 iter/sec (stddev: 2.8655594895345342e-8) 0.66
benchmarks/test_guard_cold.py::test_g8_cold_first_resolve 21768.15703012348 iter/sec (stddev: 0.0000429631749192766) 15379.490696653547 iter/sec (stddev: 0.000051149782056731814) 0.71
benchmarks/test_guard_cold.py::test_g8b_cold_first_resolve_cached 17530.55493182367 iter/sec (stddev: 0.00019855509192063134) 12235.280966323648 iter/sec (stddev: 0.00014182091799574972) 0.70
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[1] 675.325648320955 iter/sec (stddev: 0.00003577217653039623) 420.71135456065684 iter/sec (stddev: 0.00018594305917891144) 0.62
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[2] 623.2736618055136 iter/sec (stddev: 0.00016213885960953938) 424.63695666144287 iter/sec (stddev: 0.00011116096452465821) 0.68
benchmarks/test_guard_concurrency.py::test_g14_concurrent_cached_hit[4] 602.0438748164554 iter/sec (stddev: 0.00011581077801576017) 390.23759457697554 iter/sec (stddev: 0.0001419082886253107) 0.65
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[1] 19880.24801262959 iter/sec (stddev: 0.0000074639703278262015) 13440.956565966013 iter/sec (stddev: 0.000008320616697873794) 0.68
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[2] 9962.464753638471 iter/sec (stddev: 0.00001539429154651508) 6830.414858319608 iter/sec (stddev: 0.000020676695871099882) 0.69
benchmarks/test_guard_concurrency.py::test_g15_concurrent_first_resolve[4] 4989.955635132153 iter/sec (stddev: 0.00002934137790136431) 3450.271566568022 iter/sec (stddev: 0.00003227050343351025) 0.69
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[1] 15090.607781773231 iter/sec (stddev: 0.000010333181761841957) 9543.091871188262 iter/sec (stddev: 0.000009892280335513693) 0.63
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[2] 6322.8924113530375 iter/sec (stddev: 0.00001695876709810952) 4120.134893216304 iter/sec (stddev: 0.00003227935603168356) 0.65
benchmarks/test_guard_concurrency.py::test_g15b_concurrent_first_resolve_sibling_children[4] 2977.4988181178205 iter/sec (stddev: 0.000049206685656719155) 1972.6629032391627 iter/sec (stddev: 0.000039095812509512116) 0.66
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[1] 51524.3920773066 iter/sec (stddev: 0.0000028192614089911887) 36986.81943774106 iter/sec (stddev: 0.000002780457879636735) 0.72
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[2] 21535.356029661983 iter/sec (stddev: 0.000010251042382619543) 13292.149822474468 iter/sec (stddev: 0.00001902057742268964) 0.62
benchmarks/test_guard_concurrency.py::test_g15c_worker_pool_floor_control[4] 8365.852097597319 iter/sec (stddev: 0.000023830858375296732) 6385.283878829231 iter/sec (stddev: 0.00003271506212333267) 0.76
benchmarks/test_guard_lifecycle.py::test_g6_build_child_container 2197020.444817062 iter/sec (stddev: 3.350781231569425e-8) 1186412.445365853 iter/sec (stddev: 1.8668843513900605e-7) 0.54
benchmarks/test_guard_lifecycle.py::test_g6b_build_child_container_auto_scope 2374949.8366129985 iter/sec (stddev: 1.609532523803889e-8) 1439357.2003469553 iter/sec (stddev: 1.3428678864163774e-7) 0.61
benchmarks/test_guard_lifecycle.py::test_g7_request_lifecycle_batch 4500.647864027203 iter/sec (stddev: 0.000014868878246798898) 3198.347886640367 iter/sec (stddev: 0.00001689254718479216) 0.71
benchmarks/test_guard_lifecycle.py::test_g7c_event_loop_floor_control 71515.63571470644 iter/sec (stddev: 0.0000012032184873237606) 57012.95296481817 iter/sec (stddev: 0.000001988718099652445) 0.80
benchmarks/test_guard_lifecycle.py::test_g7b_request_cycle_sync 571061.4115723085 iter/sec (stddev: 7.798031232491594e-8) 417850.44568498887 iter/sec (stddev: 7.136323242194209e-8) 0.73
benchmarks/test_guard_lifecycle.py::test_g13_teardown_at_scale 89676.42005493258 iter/sec (stddev: 0.0000010314219591429331) 61913.621286827416 iter/sec (stddev: 0.0000019531112131965793) 0.69
benchmarks/test_guard_lifecycle.py::test_g13b_teardown_at_scale_async_no_finalizers 775.0937676367432 iter/sec (stddev: 0.0016442222497238868) 568.3030889187805 iter/sec (stddev: 0.000972033988201097) 0.73
benchmarks/test_guard_resolve.py::test_g1_transient_resolve 2878696.065827352 iter/sec (stddev: 2.5130811310912606e-8) 1927548.3719496308 iter/sec (stddev: 3.063321273566937e-8) 0.67
benchmarks/test_guard_resolve.py::test_g2_cached_resolve 5088004.672830484 iter/sec (stddev: 6.550543876073652e-9) 3241398.624613932 iter/sec (stddev: 3.7615505569009485e-8) 0.64
benchmarks/test_guard_resolve.py::test_g3_deep_chain 1134945.5348153112 iter/sec (stddev: 3.762927655892425e-8) 758140.6585185425 iter/sec (stddev: 3.9099946971797845e-8) 0.67
benchmarks/test_guard_resolve.py::test_g4_wide_resolve 606297.7787276104 iter/sec (stddev: 3.5620022318849034e-7) 445794.3990425741 iter/sec (stddev: 3.5823070534011334e-7) 0.74
benchmarks/test_guard_resolve.py::test_g5_cross_scope 2760267.331897837 iter/sec (stddev: 2.7600491432614325e-8) 1730340.081471371 iter/sec (stddev: 2.41925557373383e-8) 0.63
benchmarks/test_guard_resolve.py::test_g9_context_resolve 2059212.9780662006 iter/sec (stddev: 1.2379424078677346e-7) 1369613.106209817 iter/sec (stddev: 1.1454537500184037e-7) 0.67
benchmarks/test_guard_resolve.py::test_g12_override_active_resolve 1173675.8588951125 iter/sec (stddev: 3.731297096179368e-8) 663443.1071817717 iter/sec (stddev: 3.3520439752440757e-7) 0.57
benchmarks/test_guard_resolve.py::test_g18_alias_hop 4921956.23153045 iter/sec (stddev: 5.621804904459982e-9) 3257033.2049294626 iter/sec (stddev: 4.214466891837861e-8) 0.66
benchmarks/test_guard_validate.py::test_g10_validate_deep_chain 61162.4947423564 iter/sec (stddev: 0.000002799514390675536) 40784.378767373266 iter/sec (stddev: 0.000002607741145211294) 0.67
benchmarks/test_guard_validate.py::test_g11_validate_wide 37049.163548334815 iter/sec (stddev: 0.0000017622120668185893) 23413.24333119514 iter/sec (stddev: 0.000008908168999759313) 0.63
benchmarks/test_guard_validate.py::test_g11b_validate_shared_alias_chain 3608.0909418840856 iter/sec (stddev: 0.00001711482234385669) 2659.4347298794246 iter/sec (stddev: 0.000012401817418726526) 0.74

This comment was automatically generated by workflow using github-action-benchmark.

@lesnik512
lesnik512 merged commit 0c3346c into main Nov 13, 2026
24 checks passed
@lesnik512
lesnik512 deleted the fix/751-ty-rule-renames branch November 13, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduled dependency check failed

1 participant