Repository navigation
fix: keep Litestar telemetry active through user shutdown hooks - #466
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shutdown hooks added to AppConfig after bootstrapper construction ran after telemetry teardown, losing their spans. Register teardown on the constructed Litestar app so it follows the final configuration’s user hooks.
Add an exporter regression covering the late-added hook, user lifespan and hook ordering, error propagation, and automatic teardown when a lifespan or shutdown hook raises.
Validation: the exporter regression failed before the fix. All 691 tests pass with 100% line coverage; Ruff and ty pass. All 67 Litestar bootstrap tests pass on Litestar 2.25.0 and the 2.22.0 minimum. Standards and spec reviews found no issues.
Closes #456.