Repository navigation
fix: close the owned Sentry client during teardown - #464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sentry teardown previously flushed the current client and detached it without closing the client initialized by the instrument. Retain that owned client and close it with the existing two-second timeout. Clear the global binding only if it still refers to that client, preserving replacements even when cleanup raises.
Add regression tests for transport shutdown, the timeout, replacement clients, flush and kill failures, and repeated teardown. Document the async transport scope: callers must await
client.close_async(timeout=2)before synchronous teardown. Validate that path with a realAsyncHttpTransport.Validation: 686 tests pass with 100% line coverage; Ruff, ty 0.0.100, and the strict docs build pass. Standards and spec reviews found no issues.
Closes #454.