Repository navigation
docs: define redaction and skip_sentry scope for opt-in Sentry Logs - #463
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in Sentry Logs can send raw rendered JSON, including sensitive fields and records marked
skip_sentry=True. Document that built-in redaction and suppression cover issue events and breadcrumbs; callers who enable Logs must filter them throughsentry_additional_params["before_send_log"].Validated SDK recognition on sentry-sdk 2.70.0 with structlog 21.3.0 and the installed SDK 2.73.0. The Logs hook receives a plain string body and an empty hint, losing the renderer's provenance marker. Structlog and identical stdlib JSON share the same origin, so automatic recognition would require unreliable heuristics or global logging patches. Runtime behavior stays unchanged.
Add serialized-envelope contract tests for both Logs opt-in mechanisms, callback delivery, unchanged stdout, issue redaction, and identical stdlib JSON. Update the migration guide, configuration docs, and seam ADR.
Validation: 681 tests pass with 100% line coverage; Ruff, ty 0.0.100, and the strict docs build pass. Standards and spec reviews found no issues.
Closes #452.