Skip to content

fix: update renamed ty return diagnostic - #276

Merged
lesnik512 merged 1 commit into
mainfrom
fix/275-ty-renamed-ignore
Nov 13, 2026
Merged

lesnik512 merged 1 commit into
mainfrom
fix/275-ty-renamed-ignore

Conversation

@lesnik512

Copy link
Copy Markdown
Member

Scheduled CI fails with ty 0.0.103 because the response publisher's intentional return-type suppression uses the renamed invalid-return-type diagnostic. Update it to invalid-explicit-return so type checking passes with the current toolchain.

Closes #275.

Validation: reproduced the original failure with uv run --with ty==0.0.103 ty check, then confirmed it passes after the change. just install and just lint-ci pass; uv run pytest tests/test_unit.py tests/test_fake.py --no-cov passes all 469 tests (six RuntimeWarnings about unawaited mocks). PostgreSQL integration tests were not run locally.

@github-actions

Copy link
Copy Markdown

Benchmark gate

✅ gate passed

scenario msg/s delete/msg WALrec/msg WALB/msg fpi upd del dead_tup
consumer/w1/b10 1428 1.000 6.71 920 242 5000 5000 10000
consumer/w1/b100 1536 1.000 7.11 1154 243 5000 5000 10000
consumer/w2/b10 1752 1.000 6.72 923 242 5000 5000 10000
consumer/w2/b100 2190 1.000 7.11 1154 243 5000 5000 10000
consumer/w4/b10 1794 1.000 6.73 945 242 5000 5000 10000
consumer/w4/b100 1222 1.000 7.16 1190 262 5000 5000 10000
consumer/w1/b100/tfbs100 6926 0.010 6.11 1135 246 5000 5000 10000
consumer/w1/b100/interval1-10 1004 1.000 7.11 1154 243 5000 5000 10000
producer/w1/b100 4109 0.000 3.04 598 2 0 0 0
producer/w1/b100/ppt1 1130 0.000 4.04 637 1 0 0 0

Gated (fails the build): delete_calls + tuple counters (upd/del/ins) + the producer's insert_calls, exact; select_calls and other_calls within +2; wal_records within a 10% band; fetch_calls within 2x. msg/s, WAL bytes and total calls are informational (timing/FPI noise).

@lesnik512
lesnik512 merged commit 5891f13 into main Nov 13, 2026
15 checks passed
@lesnik512
lesnik512 deleted the fix/275-ty-renamed-ignore branch November 13, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduled dependency check failed

1 participant