Repository navigation
fix: update renamed ty return diagnostic - #276
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled CI fails with ty 0.0.103 because the response publisher's intentional return-type suppression uses the renamed
invalid-return-typediagnostic. Update it toinvalid-explicit-returnso type checking passes with the current toolchain.Closes #275.
Validation: reproduced the original failure with
uv run --with ty==0.0.103 ty check, then confirmed it passes after the change.just installandjust lint-cipass;uv run pytest tests/test_unit.py tests/test_fake.py --no-covpasses all 469 tests (six RuntimeWarnings about unawaited mocks). PostgreSQL integration tests were not run locally.