Repository navigation
Conversation
Signed-off-by: Chuan He <hechuan@climamind.ai>
hechuan9
marked this pull request as ready for review
November 5, 2026 15:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IF97 boiling/dew boundary functions return records with missing fields: the Gibbs branch does not assign
cv, while the region 3 Helmholtz branch does not assigncp,vt, orvp. A compiler enforcing assigned outputs rejects these calls even when a caller only needs another field.This fills the missing properties using the existing Gibbs heat-capacity expression and the thermodynamic identities
cp-cv = T*pt^2/(d^2*pd),vt = pt/(d^2*pd), andvp = -1/(d^2*pd). Previously assigned properties and the region selection are unchanged.Adds
ModelicaTest.Media.TestOnly.WaterIF97_boundaryProperties, covering both curves at 0.1, 10, 20 and 22 MPa. Heat capacities are compared to the existing Gibbs/Helmholtz boundary-property functions; volume derivatives are checked against the pressure derivatives.Fixes #1910.
Validation on Linux at startTime=stopTime=0:
bpro__cv is used without a value; passes after the change.git diff --checkpasses.Change size: 10 production lines and 42 test lines added in two files; no new public functions.