Repository navigation
Conversation
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3805. If a maintainer assigns you to #3805, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Fixes #3805
In
examples/snippets/servers/images.py, thecreate_thumbnailtool previously returnedImage(data=img.tobytes(), format="png"). Pillow'stobytes()produces raw uncompressed RGB pixel bytes lacking PNG file headers, chunks, and compression, causing downstream clients that attempt to decode the data URL (data:image/png;base64,...) to fail withUnidentifiedImageErroror invalid image decode errors.This PR encodes the resized image into a valid in-memory PNG stream via
io.BytesIO()andimg.save(buffer, format="PNG"), returning true PNG bytes. An integration test has also been added intests/server/mcpserver/test_integration.pyto verify valid PNG container headers and correct thumbnail dimensions.Motivation and Context
Fixes #3805. Clients calling
create_thumbnailexpect valid PNG encoded bytes as indicated byformat="png".How Has This Been Tested?
test_images_thumbnailtotests/server/mcpserver/test_integration.py.uv run pytest tests/server/mcpserver/test_integration.py -v(11 passed).uv run ruff checkanduv run ruff format.Breaking Changes
No breaking changes. Only fixes erroneous encoding in the example snippet.
Types of changes
Checklist
help wanted, or I'm a maintainer)Additional context
Awaiting issue assignment on #3805 to pass intake gate verification.