Skip to content

fix(client): drain paginated session-group catalogs - #3793

Closed
namtran1812 wants to merge 1 commit into
modelcontextprotocol:mainfrom
namtran1812:fix/session-group-pagination
Closed

namtran1812 wants to merge 1 commit into
modelcontextprotocol:mainfrom
namtran1812:fix/session-group-pagination

Conversation

@namtran1812

Copy link
Copy Markdown

Fixes #3792

Summary

ClientSessionGroup currently fetches only the first page of each server’s tools, resources, and prompts. Later-page components are silently omitted, leaving valid tools unavailable through group.call_tool().

Drain each catalog’s continuation cursors before registering the server’s components.

Changes

  • Follow pagination for tools, resources, and prompts.
  • Preserve naming hooks and route later-page tools to their owning session.
  • Stage the complete catalog before updating the group, so continuation-page failures leave existing registrations unchanged.
  • Detect repeated cursors to prevent endless listing loops.
  • Preserve opaque cursor values, including empty strings, and continue through empty pages when a continuation cursor exists.
  • Apply collision checks and disconnect cleanup to the complete catalog.
  • Document pagination and failure behavior.

First

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Oct 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3792.

If a maintainer assigns you to #3792, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientSessionGroup silently omits later pages of tools, resources, and prompts

1 participant