Repository navigation
Conversation
Kehrlann
marked this pull request as draft
November 2, 2026 22:04
Kehrlann
force-pushed
the
gh-1155-flush-sse-headers
branch
2 times, most recently
from
November 3, 2026 09:49
86a7d11 to
17277b3
Compare
Kehrlann
marked this pull request as ready for review
November 3, 2026 09:53
Kehrlann
force-pushed
the
gh-1155-flush-sse-headers
branch
2 times, most recently
from
November 3, 2026 11:41
4e6cc9e to
a48673e
Compare
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
gh-1155-flush-sse-headers
branch
from
November 3, 2026 12:13
a48673e to
5b28cff
Compare
chemicL
reviewed
Nov 3, 2026
Comment on lines
+623
to
+624
| // For streaming responses, we need to return SSE. Before getWriter(): the | ||
| // character encoding is ignored once the writer is taken |
Member
There was a problem hiding this comment.
The new comment is confusing to me. Is it part of a conversation with an agent?
Member
There was a problem hiding this comment.
prepareSseResponse() sets the encoding I suppose. But that context is unknown to a reader.
Hint: update your coding agent to always write comments as self-contained for the future reader, not as part of a conversation in its current context.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1155
Supersedes #1159, #1163, #1194