Repository navigation
Servlet tests: use one Tomcat per test - #1309
Merged
Merged
Conversation
Revert the core of the change of #1118, and use one Tomcat per test instead of per class. McpSyncListFilteringIntegrationTests, which shared a Tomcat and a transport per server type, now gets a fresh one for each test too. With a shared Tomcat, a stream still being written to after its client went away can corrupt a connection of a later test, which then fails with "HTTP/1.1 header parser received no bytes". Bind test Tomcats to 127.0.0.1 in TomcatTestUtil, rather than in HttpServletSseIntegrationTests only: with the wildcard address, every stop waits a full second on macOS. This makes the per-test classes as fast as, or faster than, they were with a shared Tomcat. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/sse-tests-tomcat-per-test
branch
from
November 2, 2026 20:44
339accb to
b8cb19f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr use one Tomcat per test instead of per class. This should stabilize CI flakes.
Revert the remaining classes of #1118 to one Tomcat per test: HttpServletStatelessIntegrationTests, HttpServletStatelessShared- IntegrationTests, HttpServletStreamableIntegrationTests and McpCompletionTests. McpSyncListFilteringIntegrationTests, which shared a Tomcat and a transport per server type, now gets a fresh one for each test too.
With a shared Tomcat, a stream still being written to after its client went away can corrupt a connection of a later test, which then fails with "HTTP/1.1 header parser received no bytes".
Bind test Tomcats to 127.0.0.1 in TomcatTestUtil, rather than in HttpServletSseIntegrationTests only: with the wildcard address, every stop waits a full second on macOS. This makes the per-test classes as fast as, or faster than, they were with a shared Tomcat.