Skip to content

HttpServletStreamableServerTransportProvider: avoid completing async context twice #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kehrlann merged 2 commits into from
Nov 2, 2026
Merged

HttpServletStreamableServerTransportProvider: avoid completing async context twice #1308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42978c0
HttpServletStreamableServerTransportProvider: avoid completing async …
Kehrlann Nov 2, 2026
4ff0569
Merge branch 'main' into dgarnier/streamable-double-complete
Kehrlann Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...o/modelcontextprotocol/server/transport/HttpServletStreamableServerTransportProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,7 +621,9 @@ else if (message instanceof McpSchema.JSONRPCRequest jsonrpcRequest) {
}
catch (Exception e) {
logger.error("Failed to handle request stream: {}", e.getMessage());
asyncContext.complete();
// The transport may already have completed the async context, when
// the failure comes from a message it could not send
sessionTransport.close();
}
}
else {
Expand Down
Loading