Repository navigation
HttpClientStreamableTransport#sendMessage: fix race condition on 404 response - #1306
Merged
Merged
Conversation
Kehrlann
changed the title
Kehrlann
force-pushed
the
dgarnier/fix-flakey-tests
branch
from
November 2, 2026 14:59
4d9e11b to
600c377
Compare
- There was a race condition where a 404 to a sendMessage call triggered client-side session closing. This would ultimately close the reactive chain representing HTTP connections, including the POST for the sendMessage itself if it had not completed by then. This would cancel the Mono instead of propagating the error. - This was a race condition because before closing the connection, the DefaultMcpTransportSession needed to send a DELETE to the server, and waited for the response. Cancelling happened only when DELETE finished before sendMessage() finished, so it would not show often. - This materialized in CI as errors for `test404WithSessionId`. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
dgarnier/fix-flakey-tests
branch
from
November 2, 2026 17:42
600c377 to
235f6bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test404WithSessionId.