Repository navigation
Return a handler from find in modern server repositories - #1282
Merged
Merged
Conversation
The tool and prompt repositories had separate find and call/get methods, so every tools/call and prompts/get looked the primitive up twice. That means two round trips for repositories backed by a database or remote definitions. find now returns McpAsyncTool/McpSyncTool or McpAsyncPrompt/McpSyncPrompt, which carry the definition and its handler. The call/get methods are removed from the repositories. ToolsFeature and PromptsFeature validate against the definition and invoke the handler they found. Closes #1268 Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Align the resource repositories with the tool and prompt ones: find(ctx,
uri) returns McpAsyncResource/McpSyncResource, carrying the read handler,
in place of read(ctx, request). ResourcesFeature now answers an unknown
URI with the -32602 error carrying {"uri": ...} itself, so repositories
no longer build it.
See #1268
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Kehrlann
approved these changes
Oct 26, 2026
prathamgoyal787
added a commit
to prathamgoyal787/java-sdk
that referenced
this pull request
Oct 27, 2026
Adapt to find returning the tool with its handler (modelcontextprotocol#1282): validate the Mcp-Param headers against the found tool's definition, after the required-capabilities check and before inputSchema validation, and port the tests to McpAsyncTool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1268
Tool and prompt repositories had separate
findandcall/getmethods, so every call looked theprimitive up twice. That's two round trips for repositories backed by a database or other external storage.
findnow returns the definition together with its handler:McpAsync/SyncToolRepository.find→McpAsync/SyncTool;callis removedMcpAsync/SyncPromptRepository.find→McpAsync/SyncPrompt;getis removedMcpAsync/SyncResourceRepository.find(uri)→McpAsync/SyncResource, replacingreadThe features validate against the definition they found, then call its handler.
ResourcesFeaturenow answers an unknown URI itself (
-32602with{"uri": ...}).Breaking: this changes the modern server's repository SPI, which shipped in
2.2.0-M1.