Repository navigation
fix: allow StdioClientTransport to reconnect without a new process - #1281
Open
prathamgoyal787 wants to merge 1 commit into
Open
prathamgoyal787 wants to merge 1 commit into
prathamgoyal787 wants to merge 1 commit into
Conversation
The client creates a new session, which connects the transport again, whenever it re-initializes, for instance after an initialize request timed out. StdioClientTransport started a second server process on each connect and subscribed its single-subscriber sinks again, which failed. The first process was left running, and replies still went to the abandoned session, so the client could never initialize. connect now only replaces the inbound message handler once the server process is running.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client re-initializes, for example after an
initializerequest timed out against a slow-starting server, it creates a new session, which connects the transport again.StdioClientTransportthen started a second server process and subscribed its single-subscriber sinks again, which failed. The first process was left running, and its replies still went to the abandoned session, so the client could never initialize.connectnow starts the server process once, and on later calls only replaces the inbound message handler.Added
StdioClientTransportReinitializationTests, using a small test server that ignores the firstinitialize. It fails onmainand passes with this change.