Repository navigation
fix: generate a new request id on each client request subscription - #1280
Open
prathamgoyal787 wants to merge 1 commit into
Open
prathamgoyal787 wants to merge 1 commit into
prathamgoyal787 wants to merge 1 commit into
Conversation
McpClientSession.sendRequest generated the JSON-RPC request id once, when the Mono was assembled. Subscribing to the returned Mono again, for example with retry() after an error response, sent the same id a second time, while JSON-RPC requires that a request id is not reused within a session.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
McpClientSession.sendRequestgenerated the JSON-RPC request id once, when theMonowas assembled. Subscribing to the returnedMonoagain, for example withretry()after an error response, sent the same id a second time. JSON-RPC requires that a request id is not reused within a session.The id is now generated per subscription.
Added a test to
McpClientSessionTeststhat retries a request and asserts each attempt gets a different id. It fails onmainand passes with this change. #1134 and #287 also touchsendRequest, so whichever lands second may need a small rebase.