Repository navigation
fix: answer completion/complete without ref or argument with -32602 - #1279
Open
prathamgoyal787 wants to merge 1 commit into
Open
prathamgoyal787 wants to merge 1 commit into
prathamgoyal787 wants to merge 1 commit into
Conversation
CompleteRequest requires ref and argument, so a request missing either failed to deserialize before the handler could check it. McpAsyncServer answered it with -32603 Internal error, carrying the Jackson exception message, and McpStatelessAsyncServer threw from handleRequest instead of returning a JSON-RPC error. Answer both with -32602 Invalid params, as CONTRIBUTING.md requires for a missing dispatch identifier.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CompleteRequestrequiresrefandargument, so a request missing either one failed to deserialize before the handler could check it.McpAsyncServeranswered with-32603 Internal error, carrying the Jackson exception message.McpStatelessAsyncServerthrew fromhandleRequestinstead of returning a JSON-RPC error.Both now answer with
-32602 Invalid params, which is what CONTRIBUTING.md asks for when a dispatch identifier is missing.Added
CompletionRequestValidationTests. It fails onmain(2 failures, 2 errors) and passes with this change.