Repository navigation
fix: use the referenced resource template for completion/complete - #1278
Open
prathamgoyal787 wants to merge 1 commit into
Open
prathamgoyal787 wants to merge 1 commit into
prathamgoyal787 wants to merge 1 commit into
Conversation
A completion/complete request for a resource template looked the template
up by matching its URI template against every registered template's
pattern. Another template whose pattern happens to match that string, such
as test://{category}/{id} for test://items/{itemId}, could be checked
first, and the request then failed with "Argument not found" for a valid
argument. Look the template up by its URI template first, in both
McpAsyncServer and McpStatelessAsyncServer.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
completion/completerequest for a resource template looked up the template by matching the reference's URI template against every registered template's pattern. Another template whose pattern happens to match that string could be checked first; for example,test://{category}/{id}matchestest://items/{itemId}. The request then failed with "Argument not found" for a valid argument.This change looks the template up by its exact URI template first, and only falls back to pattern matching after that. It applies to both
McpAsyncServerandMcpStatelessAsyncServer.Added
testCompletionUsesTheReferencedResourceTemplatetoResourceTemplateManagementTests. It fails onmainand passes with this change.