Skip to content

fix(deps): exclude broken drawsvg 2.5.0 - #254

Merged
jondricek merged 1 commit into
mainfrom
fix/exclude-drawsvg-2.5.0
Nov 18, 2026
Merged

jondricek merged 1 commit into
mainfrom
fix/exclude-drawsvg-2.5.0

Conversation

@jondricek

Copy link
Copy Markdown
Contributor

Summary

Fresh installations can select drawsvg 2.5.0, which raises NameError: name 'SyncedAnimationConfig' is not defined during import on Python 3.11–3.13. Because mitreattack eagerly imports its SVG exporter, this also breaks STIX data access. Exclude the broken release from package metadata and update the lockfile requirement, retaining locked drawsvg 2.4.1.

- drawsvg>=2.4.0
+ drawsvg>=2.4.0,!=2.5.0

Upstream issue: cduck/drawsvg#155

Evidence

  • Before: On Python 3.11, uv run --no-sync --with drawsvg==2.5.0 pytest -n 2 aborts while importing conftest; from mitreattack.stix20 import MitreAttackData fails with the same NameError.
    After: The built wheel declares drawsvg!=2.5.0,>=2.4.0; an installer dry run rejects combining this package with drawsvg 2.5.0.
  • just test: 297 passed, 4 skipped on Python 3.11.14.
  • Full-suite compatibility checks with drawsvg 2.4.1 and 2.4.2: each 297 passed, 4 skipped.
  • just lint, uv run ruff check, uv run ruff format --check, uv lock --check, and uv build passed.

Merge Danger

Door: One-way for the published release; the source change is reversible, but a published PyPI version cannot be overwritten.

Blast Radius: Dependencies

New resolutions exclude only the known-broken drawsvg release. Existing environments need to upgrade mitreattack-python or pin drawsvg to a working version. The fix title triggers a patch release after merge.

@sonarqubecloud

Copy link
Copy Markdown

@jondricek
jondricek merged commit 1313049 into main Nov 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant