Repository navigation
fix(deps): exclude broken drawsvg 2.5.0 - #254
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fresh installations can select drawsvg 2.5.0, which raises
NameError: name 'SyncedAnimationConfig' is not definedduring import on Python 3.11–3.13. Because mitreattack eagerly imports its SVG exporter, this also breaks STIX data access. Exclude the broken release from package metadata and update the lockfile requirement, retaining locked drawsvg 2.4.1.Upstream issue: cduck/drawsvg#155
Evidence
uv run --no-sync --with drawsvg==2.5.0 pytest -n 2aborts while importing conftest;from mitreattack.stix20 import MitreAttackDatafails with the same NameError.After: The built wheel declares
drawsvg!=2.5.0,>=2.4.0; an installer dry run rejects combining this package with drawsvg 2.5.0.just test: 297 passed, 4 skipped on Python 3.11.14.just lint,uv run ruff check,uv run ruff format --check,uv lock --check, anduv buildpassed.Merge Danger
Door: One-way for the published release; the source change is reversible, but a published PyPI version cannot be overwritten.
Blast Radius: Dependencies
New resolutions exclude only the known-broken drawsvg release. Existing environments need to upgrade mitreattack-python or pin drawsvg to a working version. The
fixtitle triggers a patch release after merge.