Skip to content

chore: update pnpm to v12.21.0 and switch to v13 lockfile format - #192

Closed
dinwwwh wants to merge 1 commit into
mainfrom
claude/pnpm-12-21-lockfile-v13
Closed

dinwwwh wants to merge 1 commit into
mainfrom
claude/pnpm-12-21-lockfile-v13

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Bump the pinned pnpm from 12.16.1 to 12.21.0 (latest), via pnpm self-update.

  • Enable the v13 lockfile format in pnpm-workspace.yaml:

    lockfile:
      format: v13

Why

The v13 format (added in pnpm 12.19) writes pnpm-lock.yaml with one entry per package version (no separate packages / snapshots sections), one value per line, and a trailing comma after every entry. A dependency or peer update then changes only the lines that record its version, so concurrent PRs hit far fewer lockfile merge conflicts.

Notes

  • No resolved dependency versions change. I compared the resolved name@version sets of the old and new lockfiles: they match, apart from pnpm's own binaries in the env lockfile document.
  • The lockfile diff is large but one-time. It's the rewrite into the new layout.
  • pnpm ≥ 12.19 is needed to read the new lockfile. pnpm 12.16.1 fails on it. The packageManager / devEngines pin makes pnpm switch to 12.21.0 automatically, and CI uses pnpm/action-setup@v6, which reads that pin.
  • v13 is marked experimental upstream. 12.21.0 includes several v13 fixes.

Testing

  • pnpm install --frozen-lockfile succeeds with pnpm 12.21.0
  • pnpm run check (or this repo's equivalent) passes

Generated by Claude Code

Bump the pinned pnpm to 12.21.0 and enable the experimental
`lockfile.format: v13` (pnpm >= 12.19). It writes pnpm-lock.yaml with one
entry per package version and one line per value, with trailing commas, so
dependency updates touch fewer lines and concurrent PRs hit fewer lockfile
merge conflicts. Resolved dependency versions are unchanged; only the pnpm
binaries in the env lockfile and the lockfile layout change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VVaw7SDgegkh5P17SW6Ewa
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated project tooling and lockfile configuration. These changes do not affect the app’s user-facing features or behavior.

The repository updates its configured pnpm version to 12.21.0 and sets the workspace lockfile format to v13.

Changes: pnpm Configuration

Layer / File(s) Summary
pnpm version and lockfile settings
package.json, pnpm-workspace.yaml
The configured pnpm version changes to 12.21.0. The workspace configuration sets lockfile format v13 and adds comments about its experimental status and expected lockfile layout.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to fbc77

This updates the pinned pnpm version and switches to the experimental v13 lockfile layout. No merge-blocking risk is evident. Contributors need pnpm 12.21.0 or later to read the lockfile.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names both changes in the PR: the pnpm bump from 12.16.1 to 12.21.0 in the root package.json, and the switch to the v13 lockfile format in pnpm-workspace.yaml. It is concise and specific, an…
Description check Passed The description covers the pnpm version bump, the v13 lockfile format enablement in pnpm-workspace.yaml, the rationale (fewer lockfile merge conflicts), and testing notes. It directly describes the ch…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names both changes in the PR: the pnpm bump from 12.16.1 to 12.21.0 in the root package.json, and the switch to the v13 lockfile format in pnpm-workspace.yaml. It is concise and specific, and a reviewer scanning history can tell the main changes.

Full details: Description check

Explanation

The description covers the pnpm version bump, the v13 lockfile format enablement in pnpm-workspace.yaml, the rationale (fewer lockfile merge conflicts), and testing notes. It directly describes the changeset.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 50401bc4-e8d8-4a03-ab1c-edede5bdbca7
Commits

Reviewing files that changed from the base of the PR and between 5e10991 and fbc7788.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2

  • package.json
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026

Copy link
Copy Markdown
@standard-server/aws-lambda

npm i https://pkg.pr.new/@standard-server/aws-lambda@192

@standard-server/core

npm i https://pkg.pr.new/@standard-server/core@192

@standard-server/fastify

npm i https://pkg.pr.new/@standard-server/fastify@192

@standard-server/fetch

npm i https://pkg.pr.new/@standard-server/fetch@192

@standard-server/node

npm i https://pkg.pr.new/@standard-server/node@192

@standard-server/peer

npm i https://pkg.pr.new/@standard-server/peer@192

@standard-server/shared

npm i https://pkg.pr.new/@standard-server/shared@192

commit: fbc7788

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

2 warnings

⚠️ Upgrade your CodSpeed plugin for Node.js 24

@codspeed/* 5.7.1 is only tested on Node.js 18, 20, and 22, so your Node.js 24 measurements may be inaccurate. Upgrade your @codspeed/* packages to 6.0.0 or later.

See affected benchmarks

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 26 untouched benchmarks
⏩ 108 skipped benchmarks1


Comparing claude/pnpm-12-21-lockfile-v13 (fbc7788) with main (5b23323)2

Open in CodSpeed

Footnotes

  1. 108 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (5e10991) during the generation of this report, so 5b23323 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — bumping the exact packageManager pin and enabling lockfile.format: v13 in pnpm-workspace.yaml is the whole mechanism; CI and Corepack both read that pin, and the large lockfile diff is the one-time rewrite into the new layout.

Reviewed changes — all three files, verified against the base lockfile rather than by reading the diff alone:

  • packageManager bump to pnpm@12.21.0 — the only pnpm version reference in the repo; every workflow uses pnpm/action-setup@v6 with no version input, so nothing else needs updating.
  • lockfile.format: v13 in pnpm-workspace.yaml — honoured by pnpm: taking the base v9 project document and running pnpm install --lockfile-only with this config present reproduces the committed file byte for byte, so the lockfile is canonical (not hand-edited) and the key is not a silent no-op.
  • pnpm-lock.yaml rewrite — the file stays multi-document (env lockfile still v9 YAML for the @pnpm/exe.* binaries incl. the new netbsd-x64; project document now v13 with projects and a single packages map). Resolved package sets are identical: 550 entries in both, same 11 projects, and the 31 peer-suffixed snapshot keys collapse to plain version keys with no collisions.

Beyond the diff, I confirmed:

  • pnpm install --frozen-lockfile passes on 12.21.0 with no lockfile churn.
  • A fresh checkout (git archive HEAD) installs cleanly with --frozen-lockfile --ignore-scripts.
  • pnpm runtime set node 24 (the CI matrix step) leaves the project document at 13.0; sherif is clean; oxfmt excludes the lockfile, so pnpm format can't rewrite the v13 document.
  • The repo has no Renovate/Dependabot config, so no third-party lockfile parser is exposed to the experimental format.

One editorial nit, no action needed: the PR body mentions a "packageManager / devEngines pin", but the repo only pins via packageManager.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

dinwwwh commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closing this for now because the v13 lockfile format is still experimental upstream. I'm keeping the branch so it can be reopened later.

Blockers I confirmed before closing:

  • Dependabot's lockfile parser (@pnpm/lockfile-file@^9.1.3 in dependabot-core) can't read lockfileVersion: 13.0. It fails with TypeError: Cannot use 'in' operator to search for 'tarball' in undefined.
  • dependabot-core ships pnpm 12.10.1. pnpm versions before 12.11 can't parse the nested lockfile: setting in pnpm-workspace.yaml.

Worth revisiting once v13 is stable and Dependabot supports it.


Generated by Claude Code

@dinwwwh dinwwwh closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants