Skip to content

chore: update pnpm to v12.21.0 and switch to v13 lockfile format - #401

Closed
dinwwwh wants to merge 1 commit into
mainfrom
claude/pnpm-12-21-lockfile-v13
Closed

dinwwwh wants to merge 1 commit into
mainfrom
claude/pnpm-12-21-lockfile-v13

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Bump the pinned pnpm from 12.16.1 to 12.21.0 (latest), via pnpm self-update.

  • Enable the v13 lockfile format in pnpm-workspace.yaml:

    lockfile:
      format: v13

Why

The v13 format (added in pnpm 12.19) writes pnpm-lock.yaml with one entry per package version (no separate packages / snapshots sections), one value per line, and a trailing comma after every entry. A dependency or peer update then changes only the lines that record its version, so concurrent PRs hit far fewer lockfile merge conflicts.

Notes

  • No resolved dependency versions change. I compared the resolved name@version sets of the old and new lockfiles: they match, apart from pnpm's own binaries in the env lockfile document.
  • The lockfile diff is large but one-time. It's the rewrite into the new layout.
  • pnpm ≥ 12.19 is needed to read the new lockfile. pnpm 12.16.1 fails on it. The packageManager / devEngines pin makes pnpm switch to 12.21.0 automatically, and CI uses pnpm/action-setup@v6, which reads that pin.
  • v13 is marked experimental upstream. 12.21.0 includes several v13 fixes.

Testing

  • pnpm install --frozen-lockfile succeeds with pnpm 12.21.0
  • pnpm run check (or this repo's equivalent) passes

Generated by Claude Code

Bump the pinned pnpm to 12.21.0 and enable the experimental
`lockfile.format: v13` (pnpm >= 12.19). It writes pnpm-lock.yaml with one
entry per package version and one line per value, with trailing commas, so
dependency updates touch fewer lines and concurrent PRs hit fewer lockfile
merge conflicts. Resolved dependency versions are unchanged; only the pnpm
binaries in the env lockfile and the lockfile layout change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VVaw7SDgegkh5P17SW6Ewa
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Updated the project’s package manager version.
    • Updated workspace lockfile settings and added formatting guidance.

The declared pnpm version changes from 12.16.1 to 12.21.0. The workspace configuration sets the lockfile format to v13 and documents that format.

Changes: pnpm Configuration

Layer / File(s) Summary
Update pnpm version and lockfile format
package.json, pnpm-workspace.yaml
The declared pnpm version changes to 12.21.0. The workspace configuration sets the lockfile format to v13 and adds a comment about the format.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 03b46

This updates the pinned pnpm version and enables the v13 lockfile format. No concrete risk was found, and the change looks safe to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the two main changes: bumping pnpm from 12.16.1 to 12.21.0 and switching the lockfile to the v13 format. Both match the package.json and pnpm-workspace.yaml changes and the stated obj…
Description check Passed The description covers the pnpm version bump, the v13 lockfile enablement in pnpm-workspace.yaml, the reason for the change, and the testing performed. It matches the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the two main changes: bumping pnpm from 12.16.1 to 12.21.0 and switching the lockfile to the v13 format. Both match the package.json and pnpm-workspace.yaml changes and the stated objectives.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 59fc8dcf-921f-45e4-935a-58d1ecb583c4
Commits

Reviewing files that changed from the base of the PR and between 784c441 and 03b4647.

Files ignored due to path filters: 1

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing: 2

  • package.json
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@openapi-spec/downgrader@401
npm i https://pkg.pr.new/@openapi-spec/router@401
npm i https://pkg.pr.new/@openapi-spec/types@401

commit: 03b4647

@codecov

codecov Bot commented Nov 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@codspeed

codspeed Bot commented Nov 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing claude/pnpm-12-21-lockfile-v13 (03b4647) with main (e4dba5c)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (784c441) during the generation of this report, so e4dba5c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — moving the pnpm pin and the lockfile format together in one commit is the right sequencing: pnpm 12.21.0 is the tool that writes and reads the v13 document, and the packageManager pin is what makes CI (pnpm/action-setup@v6) and older local pnpm installs switch to it automatically.

Reviewed changes

  • pnpm pin — packageManager moved from 12.16.1 to 12.21.0; verified against the registry, and engines.node >=18 is satisfied by the 20/22/24/26 CI matrix.
  • v13 lockfile — the project document is now lockfileVersion: "13.0": tab indentation, trailing commas, a single packages map with peer versions as properties, and no snapshots section. The boot/env document keeps its 9.0 shape and lists the new pnpm binaries.
  • format opt-in — lockfile: { format: v13 } in pnpm-workspace.yaml, confirmed effective (pnpm config get lockfile.format → v13).

Checks run locally: pnpm install --frozen-lockfile passes, a fresh pnpm install leaves the lockfile byte-identical, the resolved package set is unchanged versus main (377 entries), and pnpm check / pnpm test (377 tests) pass. CI is green, including the pkg-pr-new preview job. Dependabot's pinned lockfile parser (@pnpm/lockfile-file@9.1.3) reads the v13 document and sees all packages, so the daily update job should keep working.

One understanding worth carrying forward: v13 is still upstream-experimental, so a future pnpm release may force another one-time lockfile rewrite. That trade-off is documented in the PR description and is reasonable given the merge-conflict payoff.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) | 𝕏

dinwwwh commented Nov 18, 2026

Copy link
Copy Markdown
Member Author

Closing this for now because the v13 lockfile format is still experimental upstream. I'm keeping the branch so it can be reopened later.

Blockers I confirmed before closing:

  • Dependabot's lockfile parser (@pnpm/lockfile-file@^9.1.3 in dependabot-core) can't read lockfileVersion: 13.0. It fails with TypeError: Cannot use 'in' operator to search for 'tarball' in undefined.
  • dependabot-core ships pnpm 12.10.1. pnpm versions before 12.11 can't parse the nested lockfile: setting in pnpm-workspace.yaml.

Worth revisiting once v13 is stable and Dependabot supports it.


Generated by Claude Code

@dinwwwh dinwwwh closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants