Skip to content

[http-client-java] Upgrade Node.js dependencies - #12540

Merged
Weidong Xu (weidongxu-microsoft) merged 25 commits into
microsoft:mainfrom
weidongxu-microsoft:fix/java-dependency-alerts-20261111
Nov 11, 2026
Merged

Weidong Xu (weidongxu-microsoft) merged 25 commits into
microsoft:mainfrom
weidongxu-microsoft:fix/java-dependency-alerts-20261111

Conversation

@weidongxu-microsoft

@weidongxu-microsoft Weidong Xu (weidongxu-microsoft) commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Upgrade Node.js dependencies for the Java emitter and both test modules, including peer dependencies, overrides, and lockfiles.

  • Sync Java/POM dependency versions using eng/versioning/Sync-Versions.ps1.
  • Regenerate clients and add e2e coverage for the updated HTTP specs.
  • Fix base64/base64url encoding for byte-valued headers and query parameters.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 133b0e95-9bfb-4fa1-a39b-81613b0e8fa5
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:32
@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

All changed packages have been documented.

  • ✅ @typespec/http-client-java
Show changes

@typespec/http-client-java - fix ✏️

Fix base64 encoding of byte-valued headers and query parameters.

@typespec/http-client-java - internal ✏️

Add end-to-end coverage for updated HTTP specs and byte-valued header collections.

@typespec/http-client-java - dependencies ✏️

Upgrade Node.js dependencies and sync Java dependency versions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The dependency update is missing the required .chronus entry for @typespec/http-client-java with changeKind: dependencies describing the vulnerability remediation.

1 open issue
1 file not reviewed
  • packages/http-client-java/package-lock.json: Generated file
What changed in this PR

Updates the Java HTTP client emitter’s npm dependency tree to address reported vulnerabilities. The Eclipse runtime dependency remains unchanged.

Changes:

  • Adds scoped minimatch and glob overrides for API Extractor and rimraf.
  • Refreshes locked transitive dependencies for authentication, request parsing, and build tooling.
File Description
packages/​http-client-java/​package.json Adds targeted dependency overrides.
packages/​http-client-java/​package-lock.json Records updated versions, dependency relationships, and integrity hashes.

Review effort: Balanced

Comment thread packages/http-client-java/package.json Resolved
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:client:java Issue for the Java client emitter: @typespec/http-client-java label Nov 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 133b0e95-9bfb-4fa1-a39b-81613b0e8fa5
Copilot AI balanced review requested due to automatic review settings November 11, 2026 01:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The minimatch 10-to-11 override leaves API Extractor compatibility unverified because normal build/test scripts do not exercise extract-api and dependencies are unavailable for runtime validation.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • packages/http-client-java/package-lock.json: Generated file

Review effort: Balanced

@azure-sdk-automation

azure-sdk-automation Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

You can try these changes here

🛝 Playground 🌐 Website 🛝 VSCode Extension

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Copilot AI balanced review requested due to automatic review settings November 11, 2026 06:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The unbranded test bypasses the production template, leaving RequestContext-based query generation untested.

1 open issue
1 file not reviewed
  • packages/http-client-java/package-lock.json: Generated file

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Copilot AI balanced review requested due to automatic review settings November 11, 2026 07:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The override moves API Extractor from pinned minimatch 10.2.3 to major version 11, requiring a clean npm ci and API Extractor build in CI to verify compatibility.

1 open issue

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Copilot AI balanced review requested due to automatic review settings November 11, 2026 07:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Generated clients are written under specs and deleted before collection, while new tests reference missing client methods and source packages, preventing compilation.

3 open issues

Review effort: Balanced

@weidongxu-microsoft Weidong Xu (weidongxu-microsoft) changed the title [http-client-java] Update vulnerable npm dependencies [http-client-java] Upgrade Node.js dependencies Nov 11, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Copilot AI balanced review requested due to automatic review settings November 11, 2026 12:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Java HTTP client emitter updates.

2 open issues
1 resolved since last review

Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 265d4a1b-cb96-4da6-a97d-b76b50fb1749
Copilot AI balanced review requested due to automatic review settings November 11, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues require further changes.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Merged via the queue into microsoft:main with commit 76dd125 Nov 11, 2026
33 of 35 checks passed
@weidongxu-microsoft
Weidong Xu (weidongxu-microsoft) deleted the fix/java-dependency-alerts-20261111 branch November 11, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

emitter:client:java Issue for the Java client emitter: @typespec/http-client-java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants