Repository navigation
Fix post-0.261.439 retest findings in native evidence and tabular planning - #1939
Merged
Paul Lizer (paullizer) merged 2 commits intoNov 14, 2026
Conversation
…nning Carry a PDF /Lang and bookmark outline and a PowerPoint language into the canonical native audit facts, taking the bookmark state from the catalog /Outlines container rather than the outline reader entry count. Report how many native records were returned from the start of a chain, and escape a vertical bar only inside Markdown table rows. Give the relational_spec schema its expression grammar and column rules, correct a column that no step can have once before approval when the header is known exactly, and attach content-free codes and locations to planning rejections and execution failures, including a schema locator that prefers the operation a step names. Compare earlier source selections independent of list order, add content-free counts to missing action results and step-budget rejections, and tell the planner that showing a document content is a chat answer, not a new file. Offline only: nothing was deployed or replayed, and the failed operands, competing continuation records, action call origin and title backslash stage stay evidence-gated. Bump to 0.261.443 and renew the Cosmos inventory review for the five unchanged owners in functions_orchestration_context.py. Docs: new POST_439_RETEST_REMEDIATION_FIX.md plus updates to the tabular, accessibility and logging references. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve the CodeQL py/import-and-import-from note on three tests added in this PR, which imported functions_accessibility locally while the module also used a from-import. Patch the shared fitz module directly instead; it is the same object functions_accessibility uses, so the simulated reader failures and disagreements are unchanged. Test-only: no application behavior or version change. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Paul Lizer (paullizer)
merged commit Nov 14, 2026
ca1e4b0
into
microsoft:Development
13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A ten-case retest of 0.261.439 (35 original requests, 27 saved assistants) ended with 2 passes, 2 partial results and 6 failures. Three independent read-only investigations compared the saved runs, Application Insights traces and source behavior. This PR changes only what that evidence confirmed was wrong, and adds content-free diagnostics where the evidence could not locate the failing operand, record or stage. It is not a live acceptance result: nothing was deployed or replayed.
/Langand bookmark outline and a PowerPoint'sdc:languagewere returned by the native readers but never reached the canonical audit facts, so an answer could call them missing. They are now typed facts. The PDF bookmark state comes from the catalog's own/Root/Outlinescontainer (absent,present_empty,present_value, orinaccessiblewith a reason), not from the outline reader's entry count. Audit coverage reports how many whole records were returned from the start of a chain, so a partial read is disclosed as partial. An exact title containing a vertical bar is escaped only inside Markdown table rows, and the answer decoder restores it elsewhere.relational_specschema now carries the expression grammar and column rules the runtime enforces. When a header is known exactly, a column that no step can have is returned to the planner once before approval. Planning rejections and execution failures carry stable, content-free codes and locations (check, role, category, step), and a schema failure is located in the operation a step names even when the step has several faults.sc_*fields name the failed check, role, step and schema branch, andaction_results_missingandplan_step_budgetrejections log counts. No model text, column name, source value or document ID is recorded. No setting, limit or route changes.Linked issue
N/A (no associated GitHub issue).
Release Notes & Latest Features
Is this visible to end users?
Is this admin-facing (Admin Settings, governance, deployment, config)?
Diagnostic log fields only; no Admin Setting, governance, deployment or configuration change.
Should this become a Latest Feature card?
Screenshot needed for the card?
Version bump
application/single_app/config.pyVERSIONthird segment bumped, or not needed because this is docs-onlydeployers/version.txtbumped, or not needed becausedeployers/was not changedVERSIONgoes from 0.261.442 to 0.261.443. Nothing underdeployers/changed.Testing / validation
All commands ran offline from the repository root with
PYTHONPATH=application\single_app;functional_testsand Cosmos network access blocked (-p test_support.cosmos_network_guard). Each pytest group also ran on agit archiveof the unmodified base commit (a47100f7, 0.261.442) with the same files and options, and the failed-test sets are identical on every step.check_cosmos_response_boundaries.pycheck_cosmos_response_boundaries.py --run-contractsThe extra passing tests in groups 1 and 3 (28 and 75) are the cases added here. Step 8 ran last, on the final code.
Exact commands
Failures that also occur on the unmodified base, and are neither fixed nor worsened here:
test_orchestration_tabular_reconciliation.py::test_composition_profile_validator_accepts_only_valid_mappings,test_orchestration_deliverables.py::test_an_invalid_deliverables_plan_gets_exactly_one_repair_call,test_orchestration_action_chart_delivery.py::test_a_gather_only_plan_gets_one_correction_round, andtest_orchestration_document_action_end_to_end.py::test_native_auto_turn_reaches_a_saved_cited_answer[False-True-pdf]and[False-True-docx](the last two pass when run alone and fail only in this run order).test_excel_document_accessibility_extraction.py::test_report_and_citations_reuse_authorized_contractandtest_native_document_fidelity_pipeline.py::test_old_source_metadata_cannot_describe_a_sanitized_active_file; both raise aNameErrorforvalidate_native_report_sectionsatfunctions_search_service.py:1277.Manual validation: bookmark states were also checked against a pypdf-written emptied outline root and, read-only through scratch copies, the two original retest PDFs (tagged:
/Outlineswith 4 entries ispresent_value; untagged: no/Outlinesisabsent). No source file was modified. The two review-driven corrections and the header-spelling guard below were written test-first and seen failing before their fixes (13, 5 and 1 failures).Not run:
test_tabular_relational_analysis_helpers.pycannot be collected without real Cosmos credentials. No deployment, live replay or source upload was performed; unchanged-source live acceptance needs a separate approval.Documentation
Release notes are not included yet; an entry under 0.261.443 is still to be written. Feature docs updated:
DOCUMENT_ACCESSIBILITY_AND_STRUCTURE_EXTRACTION.md,MULTI_FILE_TABULAR_CALCULATIONS.mdand the logging reference (docs/reference/logging-tags.md, including a correcteddebug_onlynote). New fix doc:docs/explanation/fixes/POST_439_RETEST_REMEDIATION_FIX.md.Security checklist
@swagger_route(security=get_auth_security())sanitize_settings_for_user()No Flask route, settings payload, frontend asset or credential handling is added or changed. New log fields are allowlisted closed tokens or counts, and the added content was scanned for local paths, session identifiers and credential-like strings.
Notes for reviewers
present_emptyand a malformed one isinaccessible, never a falseabsent), and the schema locator now prefers the alternative whose own constant matches the step'sopbefore closeness, so correction guidance cannot tell the planner to replace aderivewithfilterfields.display_header_nameinfunctions_tabular_merge.py). The olderdatasets[].columnsassertion check has the same divergence and is intentionally left unchanged.1.2, so a continuation cursor issued by an earlier version is refused as a changed source instead of silently shifting.functional_tests/cosmos_response_boundaries.jsonchanges only the review notes and module fingerprints of five unchanged owners infunctions_orchestration_context.py, whose enclosing module changed.