Repository navigation
FIX: Upgrade ESRP tasks to Node-supported versions - #879
Conversation
Replace Node 16-backed ESRP v5 tasks with v6 across the release build stages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PR Performance Report✅ No regression detectedNo consistent slowdowns detected across all 2 environments. 0 IMPROVEMENTS 0 SLOWDOWNS 2/2 ENVIRONMENTS Coverage: 2 of 2 environments completed. Advisory result; does not block merging. Performance diagnosticsPhase times are inclusive diagnostics and must not be added together. They identify where measured time changed, not why it changed. No affected phases or call-count changes were recorded. All database tasks and timingsUnix / SQL Server 2022
Unix / SQL Server 2025
Build and measurement detailsPR head:
A consistent change requires more than 20% median paired movement, at least 1 ms between the median runtimes, and at least 80% of pairs exceeding the relative threshold in the same direction. A slowdown without enough pair agreement is reported as inconsistent. The displayed change is the median of paired before-and-after ratios. It is not recalculated from the two displayed median runtimes. Both revisions use profiling-enabled builds on the same agent and database, with alternating order and discarded warmups. Results are diagnostic and do not represent production-wheel latency. Raw samples and logs are attached to the ADO run as |
There was a problem hiding this comment.
🔵 Needs a closer look
The ESRP v6 upgrade affects release compliance gates, but compile-preview does not execute these tasks, leaving authentication, malware scanning, and signing unverified in a live pipeline across affected agents.
No open issues 🎉
What changed in this PR
Updates ESRP compliance tasks to v6 to address the Node 16 end-of-life policy blocking Official release builds.
Changes:
- Upgrades all five malware-scanning tasks from v5 to v6.
- Upgrades the shared native-extension code-signing task from v5 to v6.
- Leaves task inputs and execution conditions unchanged.
| File | Description |
|---|---|
| OneBranchPipelines/steps/compound-esrp-code-signing-step.yml | Upgrades native-extension scanning and signing tasks to v6. |
| OneBranchPipelines/stages/build-windows-single-stage.yml | Upgrades Official Windows wheel scanning to v6. |
| OneBranchPipelines/stages/build-odbc-all-stage.yml | Upgrades Official ODBC artifact scanning to v6. |
| OneBranchPipelines/stages/build-macos-single-stage.yml | Upgrades Official macOS wheel scanning to v6. |
| OneBranchPipelines/stages/build-linux-single-stage.yml | Upgrades Official Linux wheel scanning to v6. |
Review effort: Balanced
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 62.6%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.connection.connection_pool.cpp: 81.3%
mssql_python.pybind.connection.connection.cpp: 82.5%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%
mssql_python.cursor.py: 92.5%🔗 Quick Links
|
Work Item / Issue Reference
Summary
Upgrade all five
EsrpMalwareScanningtasks and the sharedEsrpCodeSigningtask from v5 to v6.The v5 tasks use a Node 16 handler that is blocked by the current agent EOL policy, causing Official Build-Release runs to fail before release artifacts can complete their compliance gates. Version 6 uses a supported Node runtime and is already used by the related
mssql-rsrelease pipelines.Validation: