Repository navigation
[AI-generated] Fix netvadapterum INF encoding corruption - #1428
Merged
Merged
Conversation
Restore the last readable INF content and normalize its Git representation according to the existing working-tree-encoding attributes. AI-generated by GitHub Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 88ab4733-b88d-4cd8-b6ef-9eb5fdf52584
Co-authored-by: NateD-MSFT <34494373+NateD-MSFT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated: This pull request was generated by GitHub Copilot at the author's request.
Summary
network/netadaptercx/netvadapter/um/netvadapterum.inf; no INF directives are changed from the last readable version..gitattributesrule continues to produce UTF-16LE with a BOM and CRLF in the working tree.git diff --check.Cause
Commit a3ca26d, merged through #1425, introduced the garbled text. Its parent still contains a readable UTF-16 file.
The underlying encoding mismatch originated in 5426a64: the file was stored as raw UTF-16 bytes even though
.gitattributesalready specifiedworking-tree-encoding=UTF-16LE-BOM, which requires Git's stored content to be UTF-8. Applying byte-level LF-to-CRLF conversion to the original UTF-16 bytes and then converting from UTF-16 to UTF-8 reproduces the corrupt blob exactly.This change restores the original text and normalizes its Git representation rather than reintroducing the raw UTF-16 blob.
Validation
netvadapterum.vcxprojpassed with the documentedUMDF_VERSION_MINOR=33andUMDF_MINIMUM_VERSION_REQUIRED=33overrides.git diff --cached --checkpassed.