Repository navigation
Fix target library hints for readonly interfaces and tuples - #64970
Open
Mahesh Rijal (maheshrijal) wants to merge 2 commits into
Open
Mahesh Rijal (maheshrijal) wants to merge 2 commits into
Mahesh Rijal (maheshrijal) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61323
Analysis
The missing-property diagnostic looks up the apparent type's symbol in the feature map, which has no entries for
ReadonlyArray,ReadonlyMap, orReadonlySet. Tuples have no symbol, so the issue's([1, 2, 3] as const).toReversed()example also misses the ES2023 library hint.Fix
Add readonly feature entries matching the bundled declarations, excluding mutable-only methods. For tuple property lookups, select
ArrayorReadonlyArrayusing the tuple's readonly flag. This also gives mutable tuples the library hint while preserving the original receiver type in diagnostics.The shared missing-name lookup now treats the readonly names like its existing entries, so unresolved readonly type names can receive TS2304 instead of a spelling suggestion.
The new compiler fixtures cover old and current libraries, partial ES2015 libraries, tuples, constrained generics, and unsupported readonly mutators. Existing baselines are unchanged. Validation included focused tests,
test:all, package builds and tests, benchmarks, lint, formatting, and module tidy checks. An initial run had macOS filesystem-watcher timeouts; subsequent full runs passed.Copilot Checklist
npx hereby validateAI assistance: Codex implemented the change; Claude Code and Gemini assisted with review.