Repository navigation
Fix pattern trigger levels on the Rigol DS1074Z - #8791
Open
ShurongCAO (CAOShurong) wants to merge 2 commits into
Open
ShurongCAO (CAOShurong) wants to merge 2 commits into
ShurongCAO (CAOShurong) wants to merge 2 commits into
Conversation
ShurongCAO (CAOShurong)
marked this pull request as ready for review
November 21, 2026 19:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the Rigol pattern-trigger item in #8669.
The DS1074Z takes a separate pattern threshold for each analog channel.
scope.channels[1].pattern_trigger_level(0.16)now sets CH2 andscope.channels[1].pattern_trigger_level()reads it back. Using the instrument-widetrigger_levelin pattern mode points the caller to the channel parameter before sending a level command.The simulator checks all four thresholds independently. The SCPI commands follow the December 2015 programming guide, p. 2-178. Tested with PyVISA-sim only. Rigol programming guide