Skip to content

Fix pattern trigger levels on the Rigol DS1074Z - #8791

Open
ShurongCAO (CAOShurong) wants to merge 2 commits into
microsoft:mainfrom
CAOShurong:fix/rigol-pattern-trigger-level
Open

ShurongCAO (CAOShurong) wants to merge 2 commits into
microsoft:mainfrom
CAOShurong:fix/rigol-pattern-trigger-level

Conversation

@CAOShurong

Copy link
Copy Markdown
Contributor

Addresses the Rigol pattern-trigger item in #8669.

The DS1074Z takes a separate pattern threshold for each analog channel. scope.channels[1].pattern_trigger_level(0.16) now sets CH2 and scope.channels[1].pattern_trigger_level() reads it back. Using the instrument-wide trigger_level in pattern mode points the caller to the channel parameter before sending a level command.

The simulator checks all four thresholds independently. The SCPI commands follow the December 2015 programming guide, p. 2-178. Tested with PyVISA-sim only. Rigol programming guide

@CAOShurong
ShurongCAO (CAOShurong) marked this pull request as ready for review November 21, 2026 19:56
@CAOShurong
ShurongCAO (CAOShurong) requested a review from a team as a code owner November 21, 2026 19:56

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant