Repository navigation
Replace a re-sent livestream revision instead of rendering it twice - #5969
Merged
Merged
Conversation
added 7 commits
October 22, 2026 16:23
An update with the same ID that leaves, joins, or moves between HowTo groupings stayed in its previous grouping and was inserted again, so it was rendered twice.
A revision received again with the same ID (e.g. after a reconnect) was inserted into its livestream session a second time, so it appeared twice in the sorted activities (and the development build threw "Activities from graph and Redux are of different size"). The fast path now skips known activities, and the slow path removes the previous entry before inserting.
…fy fast path comments
…m-resent-revision # Conflicts: # packages/core/src/reducers/activities/sort/upsert.howToWithLivestream.spec.ts
Eugene (OEvgeny)
marked this pull request as ready for review
October 28, 2026 23:57
Eugene (OEvgeny)
requested review from
William Wong (compulim),
Chris Whitten (cwhitten) and
TJ Durnford (tdurnford)
as code owners
October 28, 2026 23:57
William Wong (compulim)
approved these changes
Oct 28, 2026
Eugene (OEvgeny)
enabled auto-merge (squash)
October 29, 2026 00:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Fixed
Description
upsert()inserted a re-sent livestream revision into its session without removing its previous entry, sosortedActivitieslisted it twice. A known activity now skips the streaming fast path, and the slow path replaces its previous session entry.Design
activityMapcheck) instead of teaching the fast path to splice out the old entry.Specific Changes
sort/upsert.ts: skip the fast path for known activities; remove a revision's previous entry before inserting it into its sessionupsert.livestream.spec.ts,upsert.howToWithLivestream.spec.ts: a re-sent revision stays once in the session and insortedActivities(fast and slow path)livestream/resentRevision.html(+.entity): snapshot 1, one message with the third revision; the store and activity key list each revision once.changelog/<PR#>-<slug>.mdReview Checklist
z-index)package.jsonandpackage-lock.jsonreviewed