Repository navigation
Take input buffers in list order instead of by timestamp (backport #350) - #353
Merged
Merged
Conversation
Contributor
Author
|
This pull request is merged. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## humble #353 +/- ##
==========================================
+ Coverage 54.99% 55.69% +0.70%
==========================================
Files 99 100 +1
Lines 5899 6008 +109
Branches 922 943 +21
==========================================
+ Hits 3244 3346 +102
- Misses 2327 2330 +3
- Partials 328 332 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Hao <hao3.li@tu-dortmund.de> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 122383e)
David-LP99
force-pushed
the
mergify/bp/humble/pr-350
branch
from
November 19, 2026 08:50
6168415 to
210c955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #349.
Input buffers of one entity are ordered by timestamp. Samples that arrive within one clock tick get equal timestamps, and the strict comparison then returns the newest one. This has two effects:
rcl_takereturns N+1 before N.Main changes
The allocated list is now the only source of order, with the newest item at the head.
rmw_uxrce_find_static_input_buffer_by_ownerreturns the last match instead of comparing timestamps.put_memoryandget_memory, which moves it to the head. It used to stay in place, so the newest sample could sit at the tail.timestampstays because the lifespan check needs it.This differs from the arrival counter I proposed in #349. It needs no new field and has the same effect. Changing
<to<=is not enough, because a buffer reused in place breaks the list order. With depth 2 and arrivals C, D, E sharing one timestamp,<=leaves[D, E]and takes E first.Testing
jazzyate64d79fwith this changerollingwith this changememory.cand the functions fromtypes.c, stored and taken the wayon_topicandrmw_takedo. It covers ties, overwrites, clock jumps, two interleaved owners and a take between stores. It uses subscription-style storage only and is not part of this PR.Backports
Could a maintainer please request backports to
kiltedandjazzythrough Mergify, and tohumbleif it applies?kiltedandjazzyhave the same comparison, and I have not checkedhumble.🤖 Generated with Claude Code
This is an automatic backport of pull request #350 done by [Mergify](https://mergify.com).