Repository navigation
0.18.1: SIGHUP is a request to end; a #! script is given its name - #40
Merged
Merged
Conversation
…ith SIGTERM and SIGINT A program that took the requests over was ended by SIGHUP before it could finish in order. tests/stop_word_take_over.cpp observes it. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
… the descriptor holds Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
Sunrisepeak
changed the title
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes in 0.18.1.
kal_process_stop_requestednow takes over SIGHUP as well as SIGTERM and SIGINT, andkal_process_end_as_requestedends the program by the signal that arrived. Previously a program that took the requests over was still killed when its terminal closed, without finishing in order; mcpp's cancellation records rely on finishing in order.tests/stop_word_take_over.cppchecks the hang-up case.#!script, abinfmt_miscbinary) is started by its absolute name when that name reaches the file the descriptor holds (same device and inode). Before, it was started through the descriptor, so a script saw$0as/dev/fd/<n>; a script that locates its neighbours withdirname "$0"found none of them. mcpp's provider stub met this when it wrote beside itself into/dev/fd/ticks. Where the base directory cannot be named, or the name no longer reaches the same file, the descriptor is kept as before.tests/script_sees_its_name.cppstarts a script that writes beside itself under the name in its$0. The test fails on the previous implementation (cannot create /dev/fd/beside).The branch is
openkal-0.17.1, the name openkal's conformance job checks an implementation out at. It follows openkal by that branch until openkal 0.17.1 is published, and states the version before it is merged.Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com