Repository navigation
compat.quickjs-ng 0.17.0 on macOS and Windows - #582
Merged
Merged
Conversation
The descriptor declared Linux only. Upstream builds the same four sources with the same flags on all three platforms, and openmui's TypeScript binding embeds the engine on every desktop. macOS needs nothing more (libSystem has libm and pthreads). Windows adds _CRT_SECURE_NO_WARNINGS, as upstream's CMake does for MSVC-ABI builds. The test is no longer gated to Linux, so it now evaluates the same JavaScript on macOS and Windows. Checked locally on x86_64-linux-gnu, and for x86_64-windows-gnu under wine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The descriptor declared Linux only. Upstream builds the same four sources with the same flags on Linux, macOS and Windows (clang, and MSVC-ABI clang on Windows). openmui's TypeScript binding embeds the engine on every desktop, so it needs all three.
Changes:
xpmgainsmacosxandwindows, with the same tarball and sha256._CRT_SECURE_NO_WARNINGS, as upstream's CMake does for MSVC-ABI builds.tests/examples/quickjs-ngis no longer gated to Linux. The same JavaScript is now evaluated and checked by value on every platform.Testing: run locally on x86_64-linux-gnu. Also built for x86_64-windows-gnu and run under wine. This CI is the first macOS and MSVC-ABI run.