Skip to content

Phonon_BvK_PG on main is non-functional; finalise via #2344 #2988

Open

Description

@willend

mcstas-comps/contrib/Phonon_BvK_PG.comp is on main but does not work there:

The component was most likely imported from #2344 (8e199ae) ahead of that PR, by mistake. It is left in place for now. The review fixes from the closed #2968 (bounded root list, nf == 0 guard, own SHARE guard instead of the shared PHONON_SIMPLE, bvk_-prefixed helpers, no clashing DV/pi macros) have been ported to #2344.

We hope to finalise #2344 soon. Merging it will make the component functional on main.

🤖 Generated with Claude Code

Activity

  1. willend commented on Nov 1, 2026

    @willend
    ContributorAuthor

    OpenACC follow-up planned for Phonon_BvK_PG

    The OpenACC CI job on #2344 failed with NVC++-S-1058 Call to variadic function not supported - fprintf, coming from the bundled eigen solver (share/eigen.c). The component is NOACC, but the #pragma acc routine lines in its SHARE made nvc compile the solver for the device. As a stop-gap, lefmann/McCode@bd2d0440d removes those pragmas. CPU output is bit-identical.

    A proper OpenACC port is planned as a follow-up PR on top of #2344 (a draft PR, linked here once it opens):

    • eigen.c: replace the per-call malloc scratch with fixed-size stack arrays, guard the stdio/exit calls and the TIME_EIGENSYSTEMS counter for the GPU, and mark the solver functions acc routine.
    • Component: #pragma acc declare/update device for the force-constant tables filled in INITIALIZE. The per-neutron scratch (mode, p_call, eigenvectormode, q*) becomes TRACE locals. The CPU and GPU root finders are merged into one path without the function pointer. Then drop NOACC.
    • Target: CPU results bit-identical. GPU compile checked by CI; GPU execution still needs a GPU test.
  2. willend commented on Nov 1, 2026

    @willend
    ContributorAuthor

    Draft PR for the Phonon_BvK_PG / eigen-solver OpenACC port: #3002 (depends on #2344).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions