You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Phonon_BvK_PG on main is non-functional; finalise via #2344 #2988
The component was most likely imported from #2344 (8e199ae) ahead of that PR, by mistake. It is left in place for now. The review fixes from the closed #2968 (bounded root list, nf == 0 guard, own SHARE guard instead of the shared PHONON_SIMPLE, bvk_-prefixed helpers, no clashing DV/pi macros) have been ported to #2344.
We hope to finalise #2344 soon. Merging it will make the component functional on main.
The OpenACC CI job on #2344 failed with NVC++-S-1058 Call to variadic function not supported - fprintf, coming from the bundled eigen solver (share/eigen.c). The component is NOACC, but the #pragma acc routine lines in its SHARE made nvc compile the solver for the device. As a stop-gap, lefmann/McCode@bd2d0440d removes those pragmas. CPU output is bit-identical.
A proper OpenACC port is planned as a follow-up PR on top of #2344 (a draft PR, linked here once it opens):
eigen.c: replace the per-call malloc scratch with fixed-size stack arrays, guard the stdio/exit calls and the TIME_EIGENSYSTEMS counter for the GPU, and mark the solver functions acc routine.
Component: #pragma acc declare/update device for the force-constant tables filled in INITIALIZE. The per-neutron scratch (mode, p_call, eigenvectormode, q*) becomes TRACE locals. The CPU and GPU root finders are merged into one path without the function pointer. Then drop NOACC.
Target: CPU results bit-identical. GPU compile checked by CI; GPU execution still needs a GPU test.
Activity
willend commentedon Nov 1, 2026
OpenACC follow-up planned for Phonon_BvK_PG
The OpenACC CI job on #2344 failed with
NVC++-S-1058 Call to variadic function not supported - fprintf, coming from the bundled eigen solver (share/eigen.c). The component is NOACC, but the#pragma acc routinelines in its SHARE made nvc compile the solver for the device. As a stop-gap, lefmann/McCode@bd2d0440d removes those pragmas. CPU output is bit-identical.A proper OpenACC port is planned as a follow-up PR on top of #2344 (a draft PR, linked here once it opens):
eigen.c: replace the per-callmallocscratch with fixed-size stack arrays, guard the stdio/exitcalls and theTIME_EIGENSYSTEMScounter for the GPU, and mark the solver functionsacc routine.#pragma acc declare/update devicefor the force-constant tables filled in INITIALIZE. The per-neutron scratch (mode,p_call,eigenvectormode,q*) becomes TRACE locals. The CPU and GPU root finders are merged into one path without the function pointer. Then dropNOACC.willend commentedon Nov 1, 2026
Draft PR for the Phonon_BvK_PG / eigen-solver OpenACC port: #3002 (depends on #2344).