Skip to content

STF-2368: Build PHP 8.5.12 for the AddressSanitizer job - #322

Merged
mm-kevcenteno merged 1 commit into
mainfrom
greg/stf-2368-asan-php
Nov 14, 2026
Merged

mm-kevcenteno merged 1 commit into
mainfrom
greg/stf-2368-asan-php

Conversation

@oschwald

@oschwald oschwald commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

The "Run Clang AddressSanitizer" workflow fails on main since ubuntu-latest moved to Ubuntu 26.04. The job builds PHP 8.1.0 from source, and 8.1.0 does not compile against libxml2 2.15:

ext/libxml/libxml.c:997:35: error: incompatible function pointer types passing 'void (void *, xmlErrorPtr)' ... to parameter of type 'xmlStructuredErrorFunc' (aka 'void (*)(void *, const struct _xmlError *)')

This builds PHP 8.5.12, the current release, instead.

I ran the job's steps on Ubuntu 26.04 locally with the same clang and ASan flags:

  • PHP 8.5.12 builds.
  • The extension builds with no warnings, and dev-bin/run-ext-tests.sh passes 3 of 3.
  • phpunit with the extension loaded reports 97 tests and 22 skipped. The last passing CI run reports the same counts.

STF-2368

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated memory-safety checks to use a newer PHP release. This change affects the project’s build and validation process only; it does not alter application features or behavior. There are no user-facing changes in this update.

ubuntu-latest is now Ubuntu 26.04, which ships libxml2 2.15. PHP 8.1.0
does not compile against its const error-handler API, so the job fails
while it builds PHP.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 13, 2026 20:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The AddressSanitizer workflow now downloads and builds PHP 8.5.12 instead of PHP 8.1.0.

Changes: AddressSanitizer Workflow

Layer / File(s) Summary
Update PHP source version
.github/workflows/clang-addresssanitizer.yml
The workflow now uses PHP 8.5.12 for the source archive and extracted directory.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: horgh

Merge Risk: Minimal · up to 30839

This updates the PHP version built by the AddressSanitizer CI job so it compiles on the newer runner image. It only affects CI, and no merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: the AddressSanitizer job now builds PHP 8.5.12 instead of 8.1.0. The raw summary confirms the only changed file is the AddressSanitizer workflow, and the objectives e…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: the AddressSanitizer job now builds PHP 8.5.12 instead of 8.1.0. The raw summary confirms the only changed file is the AddressSanitizer workflow, and the objectives explain the reason (libxml2 2.15 on Ubuntu 26.04 breaks PHP 8.1.0 compilation). The title is specific and matches the changeset. The 'STF-2368' ticket prefix is acceptable and does not make the title vague.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit hops beside the build,
While PHP's newer source is tilled.
The sanitizer checks the way,
Through every step of workflow's play.
One bright version joins the run,
Then the rabbit bounds toward sun.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 964ad915-4526-4ed7-91a9-8c19fe17d4ac
Commits

Reviewing files that changed from the base of the PR and between 21bd480 and 30839da.

Files selected for processing: 1

  • .github/workflows/clang-addresssanitizer.yml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@mm-kevcenteno
mm-kevcenteno merged commit 5686436 into main Nov 14, 2026
133 checks passed
@mm-kevcenteno
mm-kevcenteno deleted the greg/stf-2368-asan-php branch November 14, 2026 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants