Skip to content

Leave the development tooling out of the Composer package - #318

Merged
horgh merged 1 commit into
maxmind:mainfrom
ChrisTX:export-ignore-ext
Nov 5, 2026
Merged

horgh merged 1 commit into
maxmind:mainfrom
ChrisTX:export-ignore-ext

Conversation

@ChrisTX

@ChrisTX ChrisTX commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Composer installs maxmind-db/reader from the GitHub archive, so everything that isn't export-ignored in .gitattributes ends up in each project's vendor/. This adds the mise and lychee configuration (mise.toml, mise.lock, lychee.toml), which are development tooling like the files already excluded.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Project configuration files are now excluded from generated source archives.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .gitattributes file now excludes /lychee.toml, /mise.lock, and /mise.toml from exported archives.

Changes: Archive exclusions

Layer / File(s) Summary
Add export-ignore rules
.gitattributes
Added export-ignore rules for /lychee.toml, /mise.lock, and /mise.toml.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: oschwald

Merge Risk: Minimal · up to 60bf1

The change excludes three development configuration files from archives. No material merge risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the exclusion of development tooling files from the Composer package.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the archive with care
Three config files are no longer there
The rules are set in lines so neat
The bundle skips them, clean and complete
Then hops away on nimble feet

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 317ba336-196b-4c0e-b6be-e7c0b3db9c52
Commits

Reviewing files that changed from the base of the PR and between 0f6aa10 and 60bf19d.

Files selected for processing: 1

  • .gitattributes

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@horgh horgh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we could remove some of these files, but not all of them.

Comment thread .gitattributes Resolved
Comment thread .gitattributes Resolved
ChrisTX added a commit to ChrisTX/aur-packages that referenced this pull request Nov 5, 2026
- maxmind-db/reader 1.14.0 instead of the lock's 1.13.1, a pinned partial
  update in prepare(): its decoder bounds the time and memory a lookup in
  a crafted database can take; upstream's Dependabot has it in
  sbpp/sourcebans-pp#1586
- Link maxmind/MaxMind-DB-Reader-php#318, which leaves the C extension's
  sources out of the Composer package, at the rule removing them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
archlinux-github pushed a commit to archlinux/aur that referenced this pull request Nov 5, 2026
- maxmind-db/reader 1.14.0 instead of the lock's 1.13.1, a pinned partial
  update in prepare(): its decoder bounds the time and memory a lookup in
  a crafted database can take; upstream's Dependabot has it in
  sbpp/sourcebans-pp#1586
- Link maxmind/MaxMind-DB-Reader-php#318, which leaves the C extension's
  sources out of the Composer package, at the rule removing them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Composer installs from the GitHub archive, which included the mise and
lychee configuration. The library's users don't need them, like the
other development files that are export-ignored already.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ChrisTX ChrisTX changed the title Leave the extension and tooling files out of the Composer package Leave the development tooling out of the Composer package Nov 5, 2026
@ChrisTX

ChrisTX commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, that makes sense, I hadn't thought of packagers building the extension from the release archive. I've dropped ext/ and package.xml, so the PR now only leaves out the mise and lychee configuration.

@horgh horgh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@horgh
horgh merged commit c4130c0 into maxmind:main Nov 5, 2026
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants