Repository navigation
Leave the development tooling out of the Composer package - #318
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
horgh
left a comment
There was a problem hiding this comment.
Thanks! I think we could remove some of these files, but not all of them.
- maxmind-db/reader 1.14.0 instead of the lock's 1.13.1, a pinned partial update in prepare(): its decoder bounds the time and memory a lookup in a crafted database can take; upstream's Dependabot has it in sbpp/sourcebans-pp#1586 - Link maxmind/MaxMind-DB-Reader-php#318, which leaves the C extension's sources out of the Composer package, at the rule removing them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- maxmind-db/reader 1.14.0 instead of the lock's 1.13.1, a pinned partial update in prepare(): its decoder bounds the time and memory a lookup in a crafted database can take; upstream's Dependabot has it in sbpp/sourcebans-pp#1586 - Link maxmind/MaxMind-DB-Reader-php#318, which leaves the C extension's sources out of the Composer package, at the rule removing them Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Composer installs from the GitHub archive, which included the mise and lychee configuration. The library's users don't need them, like the other development files that are export-ignored already. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0f6aa10 to
60bf19d
Compare
|
Thanks, that makes sense, I hadn't thought of packagers building the extension from the release archive. I've dropped |
Composer installs
maxmind-db/readerfrom the GitHub archive, so everything that isn'texport-ignored in.gitattributesends up in each project'svendor/. This adds themiseandlycheeconfiguration (mise.toml,mise.lock,lychee.toml), which are development tooling like the files already excluded.🤖 Generated with Claude Code
Summary by CodeRabbit