Repository navigation
fix(TestRoomForget): Missing direction in /messages call - #943
Merged
Merged
Conversation
In the client-server API spec, the `GET
/_matrix/client/v3/rooms/{roomId}/messages` endpoint has the query parameter
`dir` marked as required.
See https://spec.matrix.org/v1.19/client-server-api/#get_matrixclientv3roomsroomidmessages
But in this Complement test it was not supplied, causing the test to fail
on the Arminius homeserver because of the invalid request.
Here I just supply the direction `b`, because for the test the direction
shouldn't actually matter.
Signed-off-by: Rasmus Rendal <r.kjaer@famedly.com>
devonh
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the client-server API spec, the
GET /_matrix/client/v3/rooms/{roomId}/messagesendpoint has the query parameterdirmarked as required.See https://spec.matrix.org/v1.19/client-server-api/#get_matrixclientv3roomsroomidmessages
But in this Complement test it was not supplied, causing the test to fail on the Arminius homeserver because of the invalid request.
Here I just supply the direction
b, because for the test the direction shouldn't actually matter.Extra note, a quick
rg '"messages"'doesn't return any other calls with a missingdir.Pull Request Checklist