Skip to content

Drop fast-glob for tinyglobby to close #876 - #877

Merged
mathiasrw merged 1 commit into
mainfrom
fix/876
Nov 16, 2026
Merged

mathiasrw merged 1 commit into
mainfrom
fix/876

Conversation

@mathiasrw

@mathiasrw mathiasrw commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

let glob with tinyglobby in place of fast-glob. The install goes from 16 packages for globbing to 3 (tinyglobby, fdir and picomatch), and tinyglobby runs on Node 12 and later, so Node 16 stays supported.

What stays the same

  • expandDirectories is off, so a folder name finds nothing, as before. With it on, a folder name would change every file in the folder.
  • tinyglobby skips a folder it can not read without a word. rr gives it its own readdirSync, so the error is still reported and the run goes on (Give a ❌ error, not a stack trace, when a path can not be looked at #788), and a failing --exclude-glob is still a panic.
  • tinyglobby gives paths from the working folder, also for a glob from the root. A glob from the root is globbed on its own with absolute, so its files keep their full path (A file given with an absolute path is not changed #726).
  • globs in --js is tinyglobby, with sync as an alias of globSync, so code written for fast-glob that uses globs.sync keeps working.

Tests

test/fix/876.test.js checks that a folder name changes no file, and that --js has globs.globSync and globs.sync. The folder test fails with expandDirectories on. The tests of #788, #726 and --js pass as before.

@mathiasrw
mathiasrw merged commit e7a9d16 into main Nov 16, 2026
7 checks passed
@mathiasrw
mathiasrw deleted the fix/876 branch November 16, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant