Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let glob with tinyglobby in place of fast-glob. The install goes from 16 packages for globbing to 3 (tinyglobby, fdir and picomatch), and tinyglobby runs on Node 12 and later, so Node 16 stays supported.
What stays the same
expandDirectoriesis off, so a folder name finds nothing, as before. With it on, a folder name would change every file in the folder.readdirSync, so the error is still reported and the run goes on (Give a ❌ error, not a stack trace, when a path can not be looked at #788), and a failing--exclude-globis still a panic.absolute, so its files keep their full path (A file given with an absolute path is not changed #726).globsin--jsis tinyglobby, withsyncas an alias ofglobSync, so code written for fast-glob that usesglobs.synckeeps working.Tests
test/fix/876.test.jschecks that a folder name changes no file, and that--jshasglobs.globSyncandglobs.sync. The folder test fails withexpandDirectorieson. The tests of #788, #726 and--jspass as before.