Skip to content

Add a GitHub workflow to enforce issue assignment - #1119

Open
sirosen wants to merge 1 commit into
marshmallow-code:devfrom
sirosen:require-assignment
Open

sirosen wants to merge 1 commit into
marshmallow-code:devfrom
sirosen:require-assignment

Conversation

@sirosen

@sirosen sirosen commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

This approach was seen in use in pydantic and is copied here. The
workflow is essentially unchanged, but some additional comments are added
and the 'name' is converted to all-lowercase (to match our build
workflow).

Notably, in the original workflow and in this copy, PRs with no
associated issues do not auto-close. The supposition is that spam PRs
primarily target existing open issues, and we can always revise this in
the future.

Our thanks to the original author:

Co-authored-by: Victorien 65306057+Viicos@users.noreply.github.com


Two extra notes:

  1. GitHub is going to start locking down pull_request_target workflows, starting December 2nd.

    I've configured a new "Policy" for GitHub Actions on this repo, which I think will allow this workflow to fire.
    See: https://docs.github.com/en/actions/reference/security/securely-using-pull_request_target#default-policy-for-pull_request_target

    I could do some trial runs with a sockpuppet account if it seems like the policy isn't working and we need to troubleshoot it.

  2. If we adopt this more broadly, we should probably update the contributing docs. I'll plan to prep a PR for that after we try this out.

This approach was seen in use in pydantic and is copied here. The
workflow is essentially unchanged, but some additional comments are added
and the 'name' is converted to all-lowercase (to match our build
workflow).

Notably, in the original workflow and in this copy, PRs with no
associated issues do not auto-close. The supposition is that spam PRs
primarily target existing open issues, and we can always revise this in
the future.

Our thanks to the original author:

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant