Repository navigation
Conversation
This approach was seen in use in pydantic and is copied here. The workflow is essentially unchanged, but some additional comments are added and the 'name' is converted to all-lowercase (to match our build workflow). Notably, in the original workflow and in this copy, PRs with no associated issues do not auto-close. The supposition is that spam PRs primarily target existing open issues, and we can always revise this in the future. Our thanks to the original author: Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach was seen in use in pydantic and is copied here. The
workflow is essentially unchanged, but some additional comments are added
and the 'name' is converted to all-lowercase (to match our build
workflow).
Notably, in the original workflow and in this copy, PRs with no
associated issues do not auto-close. The supposition is that spam PRs
primarily target existing open issues, and we can always revise this in
the future.
Our thanks to the original author:
Co-authored-by: Victorien 65306057+Viicos@users.noreply.github.com
Two extra notes:
GitHub is going to start locking down pull_request_target workflows, starting December 2nd.
I've configured a new "Policy" for GitHub Actions on this repo, which I think will allow this workflow to fire.
See: https://docs.github.com/en/actions/reference/security/securely-using-pull_request_target#default-policy-for-pull_request_target
I could do some trial runs with a sockpuppet account if it seems like the policy isn't working and we need to troubleshoot it.
If we adopt this more broadly, we should probably update the contributing docs. I'll plan to prep a PR for that after we try this out.