Skip to content

Ignore indoor GPS9 default dates when finding video t=0 - #835

Closed
rnissl wants to merge 4 commits into
mapillary:mainfrom
rnissl:mly/03-gps9-clock
Closed

rnissl wants to merge 4 commits into
mapillary:mainfrom
rnissl:mly/03-gps9-clock

Conversation

@rnissl

@rnissl rnissl commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Treat GPS time as usable only after GPS9 day 8000 and a 10/100 ms-aligned clock (Hero 11 / Max 2 indoor default calendar).
  • CAMM extraction can stop at the first good point.

Test plan

  • existing CAMM/geo tests still pass

Rebased onto current mapillary/mapillary_tools main (d1b82ab). Independent of the GoPro Max / custom FFmpeg stack.
CAMM extract conflict with #828 resolved by keeping epoch normalization and stopping at the first usable GPS clock.

rnissl and others added 2 commits September 20, 2026 19:40
Hero 11 and Max 2 start on a fake 2021-03 calendar. Treat GPS time as usable only after day 8000 and a 10/100 ms-aligned clock. CAMM extraction can stop at the first good point.

Co-authored-by: Cursor <cursoragent@cursor.com>
Spell out the 10 ms time-of-day grid so the check does not depend on an internal dump tool.

Co-authored-by: Cursor <cursoragent@cursor.com>
@meta-cla meta-cla Bot added the cla signed label Sep 20, 2026
rnissl and others added 2 commits September 20, 2026 22:06
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@caglarpir

Copy link
Copy Markdown
Contributor

The default dates the HERO11 and MAX 2 write before they have a real GPS time are a nasty one, good catch. I can't merge it as is, though: nothing calls gps_datetime_is_valid or first_gps_only yet, so behaviour doesn't change, and GPS9 comes from GoPro's GPMF track while this changes the CAMM parser, so I'm not sure which videos it would apply to. 0.15.0 also reworked how a video's start time is read from its GPS clock (#832, #939). If you still get wrong times with 0.15.0, could you open an issue with a short clip that shows the problem? With a sample we can find a check that's more robust than a day cutoff. Closing this one in the meantime.

@caglarpir caglarpir closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants