Repository navigation
Rebuild site with Void and deploy with Actions - #9
Merged
Merged
Conversation
Rebuild makewith.jp on Void so server features (API routes, DB) can be added later, while exporting a static site for GitHub Pages for now. Pages are island pages, so they ship no client JavaScript, and sections without records stay hidden instead of showing an empty list.
The site now needs a build step, so serving the main branch root no longer works. PRs are built too, so dependency updates are checked before they reach main, while only main deploys. CI reads Node from .tool-versions to match local builds, and moves each page to x/index.html because links end with a slash while Void writes making.html, and GitHub Pages answers /making/ with a 404 without making/index.html. The custom domain comes from the Pages settings, so the CNAME file is no longer needed.
Use the shared preset like the other repositories. asdf is enabled here so Node in .tool-versions is updated too; enabledManagers is not mergeable, so the preset's npm and GitHub Actions are listed again.
The first record links to this repository, and writing a record has a few rules that otherwise live only in private notes. Written in Japanese for the people who will read and contribute records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makewith.jp を Void + React で作り直し、静的に書き出して GitHub Pages に Actions で公開する形にします。
変更点
マージの前に
Settings → Pages → Source を「GitHub Actions」に切り替えてから、間を空けずにマージしてください。今は
mainの直下をそのまま公開する設定なので、このままマージすると README などがそのまま公開されるおそれがあります。カスタムドメインは Pages の設定から使われるので、CNAMEファイルは削除しています。確認したこと
npx tsc --noEmit、npm test、npm run buildが通ることマージ後に、
/making、/making/、/about、/about/、favicon、Slack での表示、HTTPS を確かめます。