Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Android unit and instrumentation test builds will likely fail again with "Unsupported class file major version 68", which the 1.15.11 pin was there to prevent. The comment at lines 141-144 says byte-buddy 1.17.x and later ship a META-INF/versions/24 overlay. It says AGP 8.1.4's Jetifier cannot parse that overlay, and android.enableJetifier=true. 1.18.16 is newer than 1.17.7, so it has that overlay too. Fix: keep the force at 1.15.11, or ignore this bump in dependabot, until the build can run without Jetifier or on an AGP whose Jetifier handles Java 24+ class files. If 1.18.16 is kept, update the comment.
Why this was flagged
android/gradle.properties:26 sets android.enableJetifier=true, and android/build.gradle:8 uses AGP 8.1.4. Mockito 5.24.0 (lines 127-128) brings in byte-buddy and byte-buddy-agent, and configurations.all forces them for every configuration. The comment at lines 141-144 records why they were pinned: byte-buddy 1.17.7 has a META-INF/versions/24 multi-release overlay, and Jetifier fails on it with "Unsupported class file major version 68". 1.15.x is the last line without that overlay. This change forces 1.18.16, which is newer than 1.17.7, so the overlay comes back. That breaks testDebugUnitTest and androidTest dependency transforms, which pass on the base branch with 1.15.11. The comment was not updated, so it now contradicts the pinned version.
Verification: Trigger: any build that resolves a test classpath with Jetifier on. The diff changes android/build.gradle:145-146 from byte-buddy 1.15.11 to 1.18.16. The comment at lines 141-144 says 1.17.7 ships a META-INF/versions/24 overlay that this AGP's Jetifier can't parse. AGP 8.1.4 and Jetifier are still on, with no ignorelist entry for byte-buddy.
Finding ID:
f-6e0dc16f