Repository navigation
chore: bump ch.qos.logback:logback-classic from 1.2.3 to 1.6.6 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ ext { | |
| threetenbp_version = "1.3.5" | ||
| json_fire_version = "1.8.0" | ||
| slf4j_core_version = "1.6.3" | ||
| slf4j_classic_version = "1.2.3" | ||
| slf4j_classic_version = "1.6.6" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 nit (optional): This bump adds no CHANGELOG.md entry, so the next release note will not mention it. AGENTS.md and CONTRIBUTING.md:52 ask every change to add a line under Why this was flaggedThe diff changes only build.gradle:30 ( Verification: Severity: nit. The trigger is merging this PR as it stands, which changes only Finding ID: |
||
| slf4j_version = "2.0.18" | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 nit (optional): After this bump, build.gradle declares two different logback versions: logback-classic at 1.6.6 and logback-core at 1.6.3. The two are released together as a matched pair. Gradle quietly resolves logback-core to 1.6.6 through logback-classic's own dependency, so
slf4j_core_version= "1.6.3" no longer says what the tests actually run with. Fix: bumpslf4j_core_versionto "1.6.6" as well. Better still, drive both artifacts from a singlelogback_versionvariable so later Dependabot bumps cannot split them.Why this was flagged
build.gradle:43 uses
slf4j_core_version(still "1.6.3") for ch.qos.logback:logback-core. build.gradle:44 now usesslf4j_classic_version("1.6.6") for ch.qos.logback:logback-classic. On the base branch both declarations were older but separate as well. This PR makes the two halves of one library disagree on patch level. With a plain version string, Gradle's conflict resolution upgrades logback-core to the 1.6.6 that logback-classic requires transitively, so test runs still work. The declared 1.6.3 is therefore stale and misleading. A later edit that pins it strictly, or a separate Dependabot PR for logback-core, could leave mismatched logback-core/logback-classic jars on the test classpath. Only test scope is affected, and published consumers are not.Verification: In build.gradle, line 29 still has
slf4j_core_version = "1.6.3", which line 43 uses for logback-core. Line 30 now hasslf4j_classic_version = "1.6.6", which line 44 uses for logback-classic. Gradle's default conflict resolution picks the highest version, so the test classpath gets logback-core 1.6.6. This PR is what makes line 43 a dead declaration.Finding ID:
f-687bddef