Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ ext {
threetenbp_version = "1.3.5"
json_fire_version = "1.8.0"
slf4j_core_version = "1.6.3"
slf4j_classic_version = "1.2.3"
slf4j_classic_version = "1.6.6"
Comment on lines 29 to +30

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): After this bump, build.gradle declares two different logback versions: logback-classic at 1.6.6 and logback-core at 1.6.3. The two are released together as a matched pair. Gradle quietly resolves logback-core to 1.6.6 through logback-classic's own dependency, so slf4j_core_version = "1.6.3" no longer says what the tests actually run with. Fix: bump slf4j_core_version to "1.6.6" as well. Better still, drive both artifacts from a single logback_version variable so later Dependabot bumps cannot split them.

Why this was flagged

build.gradle:43 uses slf4j_core_version (still "1.6.3") for ch.qos.logback:logback-core. build.gradle:44 now uses slf4j_classic_version ("1.6.6") for ch.qos.logback:logback-classic. On the base branch both declarations were older but separate as well. This PR makes the two halves of one library disagree on patch level. With a plain version string, Gradle's conflict resolution upgrades logback-core to the 1.6.6 that logback-classic requires transitively, so test runs still work. The declared 1.6.3 is therefore stale and misleading. A later edit that pins it strictly, or a separate Dependabot PR for logback-core, could leave mismatched logback-core/logback-classic jars on the test classpath. Only test scope is affected, and published consumers are not.

Verification: In build.gradle, line 29 still has slf4j_core_version = "1.6.3", which line 43 uses for logback-core. Line 30 now has slf4j_classic_version = "1.6.6", which line 44 uses for logback-classic. Gradle's default conflict resolution picks the highest version, so the test classpath gets logback-core 1.6.6. This PR is what makes line 43 a dead declaration.

Finding ID: f-687bddef

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): This bump adds no CHANGELOG.md entry, so the next release note will not mention it. AGENTS.md and CONTRIBUTING.md:52 ask every change to add a line under ## [Unreleased], because release automation only renames that heading. Fix: add a line under ## [Unreleased] in CHANGELOG.md, e.g. "Bump test dependency ch.qos.logback:logback-classic from 1.2.3 to 1.6.6". Put it under a section such as ### Fixed, which earlier releases used for non-API changes like "Pin conventional commits (#21)".

Why this was flagged

The diff changes only build.gradle:30 (slf4j_classic_version "1.2.3" -> "1.6.6"). CHANGELOG.md is untouched, and its ## [Unreleased] heading at CHANGELOG.md:8 is still empty. AGENTS.md:81-84 and CONTRIBUTING.md:52 say release automation only renames ## [Unreleased] and never writes entries, so a change with no entry ships with an empty release note. Once this merges, the next release's notes leave out this dependency change. The base branch has no such gap because the change does not exist there. No CI check enforces changelog entries, and Dependabot PRs are exempt from the title and branch checks (AGENTS.md Gotchas 3), so nothing catches the omission.

Verification: Severity: nit. The trigger is merging this PR as it stands, which changes only slf4j_classic_version = "1.2.3" to "1.6.6" at build.gradle line 30. CHANGELOG.md is untouched, and its ## [Unreleased] heading at CHANGELOG.md:8 has no entries. AGENTS.md:81-83 and CONTRIBUTING.md:52 require a hand-written entry. The next release note leaves out this bump.

Finding ID: f-f1f2d09d

slf4j_version = "2.0.18"
}

Expand Down
Loading