Repository navigation
fix(rokt): keep paypalpayerid off the user profile and the selectPlacements event - #1013
Conversation
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 37.3% (10,379 of 16,550 baseline Java LOC left to convert). 93 Java files and 75 Kotlin files in scope. |
Binary compatibility
Compares this branch with the last version published to Maven Central, both built without R8, over the public classes and members that release keeps under their own names. It also checks that this branch's release AAR still keeps them (see the script docstring). Full japicmp HTML/XML reports are attached as the |
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 224792, "core_download_bytes": 125039, "core_install_bytes": 132292}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2509, "baseline_install_bytes": 7526, "core_dex_bytes": 224792, "core_download_bytes": 125035, "core_install_bytes": 132285}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4174200, "kit_download_bytes": 2549665, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9300132, "sdkplus_download_bytes": 7987247, "sdkplus_install_bytes": 8165359}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4174368, "kit_download_bytes": 2549752, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9300244, "sdkplus_download_bytes": 7987156, "sdkplus_install_bytes": 8165359} |
Why
The Rokt kit saves every
selectPlacementsattribute exceptsandboxto the current user. It also logs every attribute it sends to Rokt on aselectPlacementsevent. Both reach every output on the account.paypalpayeridis a PayPal account ID that never changes. It is meant for Rokt only, so it should reach neither.Programme
Support for sending
paypalpayeridto Rokt without passing it on to the account's other outputs.What changes
paypalpayeridoff the current user, besidesandbox, matched in any letter case.paypalpayeridout of its loggedselectPlacementsandselectShoppableAdsevents, matched in any letter case.paypalpayeridin the placement attributes.Linked work
None.
Rollout
Ships in the next release. No flag. Revert the change to restore the previous behaviour.
Risks
A later session's call that does not pass
paypalpayeridno longer picks it up from the saved profile. Pass it on every call where Rokt needs it. Anypaypalpayeridalready stored on the profile by an earlier release remains until the app removes or overwrites it.Who
Written by an automated coding agent and reviewed by the SDK team before merge.
Size
78 lines added and 2 removed in 5 files, most of them tests.