Skip to content

fix(rokt): keep paypalpayerid off the user profile and the selectPlacements event - #1013

Merged
jamesnrokt merged 1 commit into
mainfrom
fix/keep-paypalpayerid-off-the-user-profile-and-the
Nov 13, 2026
Merged

jamesnrokt merged 1 commit into
mainfrom
fix/keep-paypalpayerid-off-the-user-profile-and-the

Conversation

@jamesnrokt

Copy link
Copy Markdown
Collaborator

Why

The Rokt kit saves every selectPlacements attribute except sandbox to the current user. It also logs every attribute it sends to Rokt on a selectPlacements event. Both reach every output on the account. paypalpayerid is a PayPal account ID that never changes. It is meant for Rokt only, so it should reach neither.

Programme

Support for sending paypalpayerid to Rokt without passing it on to the account's other outputs.

What changes

  • The Rokt kit keeps paypalpayerid off the current user, beside sandbox, matched in any letter case.
  • The kit leaves paypalpayerid out of its logged selectPlacements and selectShoppableAds events, matched in any letter case.
  • Rokt still receives paypalpayerid in the placement attributes.
  • Unit tests cover the profile write, the event and the attributes sent to Rokt.

Linked work

None.

Rollout

Ships in the next release. No flag. Revert the change to restore the previous behaviour.

Risks

A later session's call that does not pass paypalpayerid no longer picks it up from the saved profile. Pass it on every call where Rokt needs it. Any paypalpayerid already stored on the profile by an earlier release remains until the app removes or overwrites it.

Who

Written by an automated coding agent and reviewed by the SDK team before merge.

Size

78 lines added and 2 removed in 5 files, most of them tests.

@jamesnrokt
jamesnrokt requested a review from a team as a code owner November 13, 2026 14:35
@jamesnrokt jamesnrokt added the promoted Opened from Rokt's internal review process label Nov 13, 2026 — with Rokt Releases
@github-actions

Copy link
Copy Markdown

Kotlin migration progress

No change to the Java left to convert.

Module Kotlin LOC Java LOC Java staying (facade) Java left to convert Kotlin share
android-core 9,661 16,341 9,716 6,625 37.2%
android-kit-base 601 5,405 1,651 3,754 10.0%
Total 10,262 21,746 11,367 10,379 32.1%

Conversion progress: 37.3% (10,379 of 16,550 baseline Java LOC left to convert). 93 Java files and 75 Kotlin files in scope.

@github-actions

Copy link
Copy Markdown

Binary compatibility

  • ✅ android-core is compatible with 6.1.10 (112 classes compared, 0 with additions only).
  • ✅ android-kit-base is compatible with 6.1.10 (37 classes compared, 0 with additions only).

Compares this branch with the last version published to Maven Central, both built without R8, over the public classes and members that release keeps under their own names. It also checks that this branch's release AAR still keeps them (see the script docstring). Full japicmp HTML/XML reports are attached as the api-compat-reports workflow artifact. This check is not in the required-check set yet, so a red result here does not block merging.

@jamesnrokt
jamesnrokt merged commit be0cd46 into main Nov 13, 2026
45 checks passed
@jamesnrokt
jamesnrokt deleted the fix/keep-paypalpayerid-off-the-user-profile-and-the branch November 13, 2026 14:47
@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

What the SDK adds to a minified release APK.

mParticle Core SDK

Measured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.

Metric Target branch This PR Change
APK size 121.84 KB 121.83 KB -4 bytes
Download size 119.65 KB 119.65 KB 0 bytes
Dex bytes 219.52 KB 219.52 KB 0 bytes

mParticle Core + Rokt kit

Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see size-report-rokt/README.md.

Metric Target branch This PR Change
APK size 1.26 MB 1.26 MB 0 bytes
Download size 1.25 MB 1.25 MB +87 bytes
Dex bytes 2.24 MB 2.24 MB +168 bytes

Rokt SDK+ umbrella (adds the payment extension)

Metric Target branch This PR Change On top of mParticle Core + Rokt kit
APK size 6.55 MB 6.55 MB 0 bytes +5.29 MB
Download size 6.43 MB 6.43 MB -91 bytes +5.19 MB
Dex bytes 7.12 MB 7.13 MB +112 bytes +4.89 MB

➡️ SDK size impact change is minimal.

Raw measurements

core, Target branch:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 224792, "core_download_bytes": 125039, "core_install_bytes": 132292}

core, This PR:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2509, "baseline_install_bytes": 7526, "core_dex_bytes": 224792, "core_download_bytes": 125035, "core_install_bytes": 132285}

rokt, Target branch:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4174200, "kit_download_bytes": 2549665, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9300132, "sdkplus_download_bytes": 7987247, "sdkplus_install_bytes": 8165359}

rokt, This PR:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4174368, "kit_download_bytes": 2549752, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9300244, "sdkplus_download_bytes": 7987156, "sdkplus_install_bytes": 8165359}

Measured ac5097a merged into 3a522f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

promoted Opened from Rokt's internal review process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants