Repository navigation
ci(android SDK): remove the Docker-based test report action - #1011
Conversation
Kotlin migration progressNo change to the Java left to convert.
Conversion progress: 31.5% (11,339 of 16,550 baseline Java LOC left to convert). 96 Java files and 72 Kotlin files in scope. |
Binary compatibility
Compares this branch with the last version published to Maven Central, both built without R8, over the public classes and members that release keeps under their own names. It also checks that this branch's release AAR still keeps them (see the script docstring). Full japicmp HTML/XML reports are attached as the |
📦 SDK Size Impact ReportWhat the SDK adds to a minified release APK. mParticle Core SDKMeasured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.
mParticle Core + Rokt kitMeasured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see
Rokt SDK+ umbrella (adds the payment extension)
➡️ SDK size impact change is minimal. Raw measurementscore, Target branch: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 223684, "core_download_bytes": 124574, "core_install_bytes": 131827}core, This PR: {"baseline_dex_bytes": 0, "baseline_download_bytes": 2512, "baseline_install_bytes": 7528, "core_dex_bytes": 223684, "core_download_bytes": 124583, "core_install_bytes": 131836}rokt, Target branch: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4173692, "kit_download_bytes": 2548320, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9297648, "sdkplus_download_bytes": 7987547, "sdkplus_install_bytes": 8165359}rokt, This PR: {"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4173692, "kit_download_bytes": 2548319, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9297648, "sdkplus_download_bytes": 7987547, "sdkplus_install_bytes": 8165359} |
Why
The
Unit Testsjob fails on every run seen since 11 November because the third-party actionasadmansr/android-test-report-actioncannot build its Docker image. Its Dockerfile isFROM ubuntu:18.04withapt-get install python, and the build now fails withCould not resolve 'archive.ubuntu.com'. A Docker action builds during job setup, so the failure skips the checkout, the unit tests, the public API dump check and the API classification. It failed on four attempts of run 43045812676 and on a re-run of run 42903830008, which had passed the day before. The action was last released in March 2020.Programme
Standalone fix — no programme.
What changes
Removes the "Print Android Unit Tests Report" step from
.github/workflows/pull-request.ymland.github/workflows/daily.yml. The step only printed a test summary. TheArchive Unit Test Resultsstep still uploads the Gradle reports, and./gradlew teststill fails the job when a test fails, so no check is lost.Linked work
So that the
Unit Testsjob can run on #1005 and #1006, which cannot run it until this lands. A replacement report step, if wanted, is a separate change.Rollout
Merging changes no shipped artifact. Reverting is a single
git revert.Risks
./gradlew testis its own step and fails the job, and the Gradle reports are still archived →Unit Testson this pull request.Unit Testsrun on this pull request.Who
Written by an AI coding agent at a maintainer's request, and reviewed by an independent review agent before opening.
Size
6 lines removed in 2 files.