Skip to content

ci(android SDK): remove the Docker-based test report action - #1011

Merged
nickolas-dimitrakas merged 1 commit into
mainfrom
ci/remove-the-docker-based-test-report-action
Nov 11, 2026
Merged

nickolas-dimitrakas merged 1 commit into
mainfrom
ci/remove-the-docker-based-test-report-action

Conversation

@nickolas-dimitrakas

Copy link
Copy Markdown
Contributor

Why

The Unit Tests job fails on every run seen since 11 November because the third-party action asadmansr/android-test-report-action cannot build its Docker image. Its Dockerfile is FROM ubuntu:18.04 with apt-get install python, and the build now fails with Could not resolve 'archive.ubuntu.com'. A Docker action builds during job setup, so the failure skips the checkout, the unit tests, the public API dump check and the API classification. It failed on four attempts of run 43045812676 and on a re-run of run 42903830008, which had passed the day before. The action was last released in March 2020.

Programme

Standalone fix — no programme.

What changes

Removes the "Print Android Unit Tests Report" step from .github/workflows/pull-request.yml and .github/workflows/daily.yml. The step only printed a test summary. The Archive Unit Test Results step still uploads the Gradle reports, and ./gradlew test still fails the job when a test fails, so no check is lost.

Linked work

So that the Unit Tests job can run on #1005 and #1006, which cannot run it until this lands. A replacement report step, if wanted, is a separate change.

Rollout

Merging changes no shipped artifact. Reverting is a single git revert.

Risks

  • Removing the step could hide a test failure → ./gradlew test is its own step and fails the job, and the Gradle reports are still archived → Unit Tests on this pull request.
  • The workflow YAML could break → the diff is two three-line deletions → the Unit Tests run on this pull request.

Who

Written by an AI coding agent at a maintainer's request, and reviewed by an independent review agent before opening.

Size

6 lines removed in 2 files.

@github-actions

Copy link
Copy Markdown

Kotlin migration progress

No change to the Java left to convert.

Module Kotlin LOC Java LOC Java staying (facade) Java left to convert Kotlin share
android-core 8,640 17,301 9,716 7,585 33.3%
android-kit-base 601 5,405 1,651 3,754 10.0%
Total 9,241 22,706 11,367 11,339 28.9%

Conversion progress: 31.5% (11,339 of 16,550 baseline Java LOC left to convert). 96 Java files and 72 Kotlin files in scope.

@github-actions

Copy link
Copy Markdown

Binary compatibility

  • ✅ android-core is compatible with 6.1.10 (112 classes compared, 0 with additions only).
  • ✅ android-kit-base is compatible with 6.1.10 (37 classes compared, 0 with additions only).

Compares this branch with the last version published to Maven Central, both built without R8, over the public classes and members that release keeps under their own names. It also checks that this branch's release AAR still keeps them (see the script docstring). Full japicmp HTML/XML reports are attached as the api-compat-reports workflow artifact. This check is not in the required-check set yet, so a red result here does not block merging.

@github-actions

Copy link
Copy Markdown

📦 SDK Size Impact Report

What the SDK adds to a minified release APK.

mParticle Core SDK

Measured against an empty baseline app. Unlike the Rokt kit, android-core ships no Compose and no resources, so there is nothing here that a host app would already provide.

Metric Target branch This PR Change
APK size 121.38 KB 121.39 KB +10 bytes
Download size 119.20 KB 119.21 KB +10 bytes
Dex bytes 218.44 KB 218.44 KB 0 bytes

mParticle Core + Rokt kit

Measured against a Compose + Material3 reference app, so these are the costs on top of an app that already ships Compose. The reference app's dependencies are a documented convention, not a measured average: see size-report-rokt/README.md.

Metric Target branch This PR Change
APK size 1.26 MB 1.26 MB 0 bytes
Download size 1.25 MB 1.25 MB -1 bytes
Dex bytes 2.24 MB 2.24 MB 0 bytes

Rokt SDK+ umbrella (adds the payment extension)

Metric Target branch This PR Change On top of mParticle Core + Rokt kit
APK size 6.55 MB 6.55 MB 0 bytes +5.29 MB
Download size 6.43 MB 6.43 MB 0 bytes +5.19 MB
Dex bytes 7.12 MB 7.12 MB 0 bytes +4.89 MB

➡️ SDK size impact change is minimal.

Raw measurements

core, Target branch:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2513, "baseline_install_bytes": 7529, "core_dex_bytes": 223684, "core_download_bytes": 124574, "core_install_bytes": 131827}

core, This PR:

{"baseline_dex_bytes": 0, "baseline_download_bytes": 2512, "baseline_install_bytes": 7528, "core_dex_bytes": 223684, "core_download_bytes": 124583, "core_install_bytes": 131836}

rokt, Target branch:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4173692, "kit_download_bytes": 2548320, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9297648, "sdkplus_download_bytes": 7987547, "sdkplus_install_bytes": 8165359}

rokt, This PR:

{"baseline_dex_bytes": 1829108, "baseline_download_bytes": 1240062, "baseline_install_bytes": 1300934, "kit_dex_bytes": 4173692, "kit_download_bytes": 2548319, "kit_install_bytes": 2623275, "sdkplus_dex_bytes": 9297648, "sdkplus_download_bytes": 7987547, "sdkplus_install_bytes": 8165359}

Measured 9f1f932 merged into a997a8e

@nickolas-dimitrakas
nickolas-dimitrakas marked this pull request as ready for review November 11, 2026 17:54
@nickolas-dimitrakas
nickolas-dimitrakas requested a review from a team as a code owner November 11, 2026 17:54
@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Nov 11, 2026
@nickolas-dimitrakas
nickolas-dimitrakas merged commit 1fc54ee into main Nov 11, 2026
89 of 90 checks passed
@nickolas-dimitrakas
nickolas-dimitrakas deleted the ci/remove-the-docker-based-test-report-action branch November 11, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants