Skip to content

[darwin] Restore pipe file metadata - #395

Open
hugojosealmeida wants to merge 2 commits into
lsof-org:masterfrom
hugojosealmeida:fix/darwin-pipe-file-info
Open

hugojosealmeida wants to merge 2 commits into
lsof-org:masterfrom
hugojosealmeida:fix/darwin-pipe-file-info

Conversation

@hugojosealmeida

Copy link
Copy Markdown
Contributor

Populate pipe access modes, offsets, and flags using the existing file-info helper, including pipe-backed Mach fileports. Extend LTbasic2 with a small regression check for pipe access modes.

@hugojosealmeida

Copy link
Copy Markdown
Contributor Author

OpenBSD:

  FAIL: tests/LTbasic2
  ====================
  
  ERROR!!!  pipe access modes missing or incorrect.
  Testing round 0
  FAIL tests/LTbasic2 (exit status: 1)

So OpenBSD doesn’t report DTYPE_PIPE descriptors at all, no pipe entries, no access modes, nothing to validate. The test therefore saw pipes_found == 0 and failed.

Comment thread tests/LTbasic2.c
fd = -1;
pipes_found = 0;
pipes_seen = 0;
if (pipe(pipefd)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create pipe only once before loop?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants