Repository navigation
[darwin] Restore pipe file metadata - #395
Open
hugojosealmeida wants to merge 2 commits into
Open
hugojosealmeida wants to merge 2 commits into
hugojosealmeida wants to merge 2 commits into
Conversation
Contributor
Author
|
OpenBSD: So OpenBSD doesn’t report DTYPE_PIPE descriptors at all, no pipe entries, no access modes, nothing to validate. The test therefore saw pipes_found == 0 and failed. |
jiegec
reviewed
Nov 16, 2026
| fd = -1; | ||
| pipes_found = 0; | ||
| pipes_seen = 0; | ||
| if (pipe(pipefd)) { |
Member
There was a problem hiding this comment.
Create pipe only once before loop?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Populate pipe access modes, offsets, and flags using the existing file-info helper, including pipe-backed Mach fileports. Extend LTbasic2 with a small regression check for pipe access modes.