Skip to content

Add DataPacket sender oneof for packets sent on behalf of another participant #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1egoman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add DataPacket sender oneof for packets sent on behalf of another participant #1965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/data-packet-sender-identity.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

Add a `sender` oneof (`sender_identity` / `sender_hidden`) to `DataPacket`, which the SFU sets to the real sender when an agent sends a packet on behalf of another participant
69 changes: 64 additions & 5 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 13 additions & 1 deletion protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,19 @@ message DataPacket {
// sid of the user that sent the message
string participant_sid = 17;

// NEXT_ID: 19
// The participant that actually sent this packet, when `participant_identity` names a different
// participant (an agent sending a text stream or chat message on behalf of another participant).
// Set only by the SFU, which clears any value a client sends; unset when `participant_identity` is
// the real sender. Available from server protocol 20.
oneof sender {
// identity of the participant that actually sent this packet
string sender_identity = 19;
// the participant that actually sent this packet is hidden, so its identity is withheld; only
// ever true
bool sender_hidden = 20;
}

// NEXT_ID: 21
Comment on lines +474 to +486

@1egoman 1egoman Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: I am assuming currently I am ok to keep this non optional because it would be paired with a SFU protocol version bump.

But I'm not 100% sure about that, is the goal that the protobufs in here should remain backwards compatible with older SFU versions as well as the latest?

@boks1971 boks1971 Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine. The dependencies are updated. If we have to go back to pinning a different hash, will have to change the corresponding code.

}

message EncryptedPacket {
Expand Down
Loading