Repository navigation
Name state errors as a compiler would on the state machine - #168
Merged
Merged
Conversation
The summary said the call is rejected when the receiver is in a state and allowed in another, and the legend marked states as call rejected, call allowed, or allowed but not reachable. Say invalid method call, then the expected and actual states, as the Verification tab and compilers do, and mark the actual states as expected or not and the other expected states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 26, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
added a commit
that referenced
this pull request
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The State Machine view described a state error in its own words: "
x.m()is rejected whenxis in state A · allowed in state B", with a legend of Call rejected, Call allowed and Allowed, but not reachable here for the possible and accepted states. It now uses the terms of a compiler error, as the Verification tab does (Expected / Found):x.m()· expected stateBorC· actual stateAunknown.expected state tilingSet and compressionExplicit · actual state startTiling and compressionExplicit.x.m(), or Invalid method call at line N.Second error of the same file,
param.setCompressionQuality():The summary drops the receiver, which is already in the call.
Testing
npm run test:unit(107 passed),tsc -p tsconfig.test.json, webpack build.ImageWriteParamstudy exercise (screenshots above).Independent of #167 (shows the conditions by default); both touch the State Machine view but not the same lines.
🤖 Generated with Claude Code