Skip to content

Fade dimmed diagram parts less in light themes and count errors on Verification - #166

Merged
CatarinaGamboa merged 1 commit into
mainfrom
feat/light-dim-and-verification-badge
Oct 26, 2026
Merged

CatarinaGamboa merged 1 commit into
mainfrom
feat/light-dim-and-verification-badge

Conversation

@CatarinaGamboa

Copy link
Copy Markdown
Collaborator

Description

Built on #165, so until #165 is merged this PR also shows its two commits; only the last commit is new. It targets main so it cannot be stranded on the #165 branch.

  • Dimmed parts in light themes. Dimmed states, transitions, and methods had opacity: 0.25, which on white left the method names barely readable. The opacity is now --lj-dimmed-opacity: 0.25 as before, and 0.5 in light themes. Dark themes are unchanged.
  • Error count on Verification. The Verification tab shows the number of errors in the current file, the same number as Current file in its header, in the red badge. So that the two badges do not compete, the State Machine badge now uses VS Code's neutral badge colour: its state errors are already among the errors counted on Verification. Both counts stay up to date while the State Machine tab is open.

Screenshots

The UDP chat client with three state errors (receive after a possible close, bind on a bound socket, connect after close), so both badges show.

Light theme, before and after

Light theme before: dimmed methods barely readable Light theme after: dimmed methods readable, Verification badge red and State Machine badge neutral

The badges, light and dark

Light theme Verification tab with both badges

Dark theme Verification tab with both badges

Dark theme, after (the dimming is unchanged)

Dark theme state machine

Tests

  • npm run lint and npm run test:typecheck: clean.
  • npm run test:unit: 99 passed. New tests:
    • script.spec.ts: the Verification badge counts the current file's errors in red, the State Machine badge is neutral, and both update on the State Machine tab and disappear when the errors are fixed;
    • styles.spec.ts: the dimmed opacity is 0.25, and 0.5 in light themes.
  • npm test (VS Code): 9 + 1 passing. Server mvn test and the local smoke test: passed.

🤖 Generated with Claude Code

@CatarinaGamboa
CatarinaGamboa force-pushed the feat/light-dim-and-verification-badge branch from 3949519 to f0390a9 Compare October 26, 2026 14:48
…rification

Dimmed states and methods were barely readable on white, so light themes use a
higher opacity. The Verification tab shows the number of errors in the current
file in red, and the State Machine tab shows its state errors in the neutral
badge colour, since Verification already counts them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CatarinaGamboa
CatarinaGamboa force-pushed the feat/light-dim-and-verification-badge branch from f0390a9 to 9df4844 Compare October 26, 2026 15:44
@CatarinaGamboa
CatarinaGamboa merged commit 9e15d24 into main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant