Repository navigation
Conversation
The GCond was allocated with the deprecated g_cond_new() and never freed, and the mutex was never cleared. Embed both in the struct and use g_cond_init()/g_cond_clear() and g_mutex_clear(), so nothing is allocated (and nothing leaks) per progress info. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nemo_progress_info_init()allocated aGCondwith the deprecatedg_cond_new()that was never freed, and theGMutexwas never cleared either. That leaks 16 bytes per progress info.Embed the
GCondin the struct (likeinfo_lockalready is) and useg_cond_init()/g_cond_clear()/g_mutex_clear(), so nothing is allocated per info any more.Testing
A small program that creates and unrefs three progress infos, built with AddressSanitizer: 48 bytes leaked in 3 allocations before, none after. Only the file itself was compile-checked in a full Nemo build context.
🤖 Generated with Claude Code