Repository navigation
Add minimize button to the file operations progress window - #3875
Open
fortepadronrolando wants to merge 2 commits into
Open
fortepadronrolando wants to merge 2 commits into
fortepadronrolando wants to merge 2 commits into
Conversation
Replaces the window manager's default title bar with a GtkHeaderBar exposing both minimize and close controls, so the copy/move/delete progress window can be minimized to the taskbar and restored from it, similar to Windows Explorer's file operation dialog, instead of only being hideable to the status tray icon. Also switches the window type hint from DIALOG to NORMAL and explicitly clears the skip-taskbar hint, since DIALOG-hinted windows are commonly excluded from the taskbar by window managers, which would otherwise make the new minimize button a dead end.
The header bar approach conflicted with something in at least one tested environment (Cinnamon/Muffin + XAppGtkWindow), making the window's title bar disappear entirely instead of gaining a minimize button. Since the window's type hint is now NORMAL (not DIALOG) and the skip-taskbar hint is explicitly cleared, the window manager draws its own title bar for this window like any other normal window — which already includes a minimize button whenever the desktop's configured button layout has one (the common case, e.g. Cinnamon/GNOME/MATE defaults). This is simpler and avoids the CSD/decoration conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the window manager's default title bar with a
GtkHeaderBarthat shows both a minimize and a close button, so the copy/move/delete progress window can be minimized to the taskbar and restored from it — similar to Windows Explorer's file operation dialog — instead of only being hideable to the status tray icon.Also switches the window's type hint from
DIALOGtoNORMALand explicitly clears the skip-taskbar hint, sinceDIALOG-hinted windows are commonly excluded from the taskbar by window managers, which would otherwise make the new minimize button a dead end.Test plan
meson setup build && ninja -C build src/nemoon Linux Mint 22.3 (Cinnamon 6.8.3); builds cleanly with no new warnings.dbus-run-sessioninstance that the progress window now shows a minimize button next to close, and that minimizing sends it to the taskbar where it can be restored.